-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Make KafkaMetrics refresh interval configurable #6319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make KafkaMetrics refresh interval configurable #6319
Conversation
Signed-off-by: spryslmatej <spryslmatej@gmail.com>
|
@spryslmatej I removed a few ctors to make the changes smaller (we should not support all the possible combinations or all the parameters). Could you please check if this is usable for you? |
shakuzen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we couldn't use the MeterRegistry's step by default if a refresh interval isn't provided. We could only do that for PushMeterRegistry with PushRegistryConfig, but it might alleviate some need to pass a custom refresh interval.
|
I like this idea, I assume you were also thinking about getting the I tried to implement it but I realized that our registries do not return their config objects. I'm not sure we can "fix" this on the public <T extends PushRegistryConfig> T getConfig() {
return (T) config;
}Let's discuss this internally and see what we can do. |
|
I created #6342, in the meantime, we can go with the refresh interval parameter in this PR. |
|
@spryslmatej A new SNAPSHOT release should be created in the next few minutes, could you please check if it works for you? |
|
@jonatan-ivanov Tested with version Thank you very much! |
Signed-off-by: Johnny Lim <izeye@naver.com>
See #6206