Skip to content

Conversation

@dependabot
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Aug 19, 2025

Bumps io.prometheus:prometheus-metrics-bom from 1.3.10 to 1.4.1.

Release notes

Sourced from io.prometheus:prometheus-metrics-bom's releases.

v1.4.1

What's Changed

🏕 Features

Full Changelog: prometheus/client_java@v1.4.0...v1.4.1

v1.4.0

What's Changed

Unicode support

UTF-8 is now supported for metric and label names!

  • this is a backwards compatible change
    • only Prometheus servers that can handle UTF-8 will actually see it
    • otherwise you'll still get the same _ replacement characters as before
  • in the push gateway, you have to enable UTF-8 support explicitly
  • unit names still do not support UTF-8
  • refer to the documentation for details

🏕 Features

🧹 Chore

👒 Dependencies

... (truncated)

Commits
  • 8da6c1e add missing builder method for escaping scheme (#1518)
  • f613ab4 UTF-8 support in metric and label names (#1255)
  • ff23461 Update otel/opentelemetry-collector-contrib Docker tag to v0.132.4 (#1517)
  • a24cf80 Update dependency mise to v2025.8.12 (#1516)
  • aab5ad3 Update dependency org.apache.maven.plugins:maven-javadoc-plugin to v3.11.3 (#...
  • e16e771 Update dependency com.google.protobuf:protobuf-java to v4.32.0 (#1513)
  • 3aae6f4 Update dependency org.mockito:mockito-core to v5.19.0 (#1514)
  • fb56734 add Nullaway (#1511)
  • df6c250 Update otel/opentelemetry-collector-contrib Docker tag to v0.132.2 (#1510)
  • fc5aba4 Update grafana/grafana Docker tag to v12.1.1 (#1509)
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added this to the 1.16.x milestone Aug 19, 2025
@dependabot dependabot bot added dependencies Pull requests that update a dependency file java Pull requests that update Java code labels Aug 19, 2025
@github-actions github-actions bot enabled auto-merge (squash) August 19, 2025 06:36
@shakuzen
Copy link
Member

Some tests are failing like the following:

PrometheusNamingConventionTest > formatTagKey() FAILED
    java.lang.AssertionError: 
    Expecting actual:
      "_23_abc__:id__"
    to start with:
      "_23_abc___id__"
        at io.micrometer.prometheusmetrics.PrometheusNamingConventionTest.formatTagKey(PrometheusNamingConventionTest.java:38)

With the UTF-8 support added in the Prometheus client 1.4.0, it seems : is no longer replaced to an underscore (_).

@shakuzen
Copy link
Member

@fstab it seems : does not get converted to _ in 1.4.1 but it did in 1.3.10. Is that change intentional? We're calling PrometheusNaming.prometheusName and PrometheusNaming.sanitizeMetricName and PrometheusNaming.sanitizeLabelName. See our PrometheusNamingConvention and the failing tests (formatName and formatTagKey) in PrometheusNamingConventionTest.

@jonatan-ivanov
Copy link
Member

I opened prometheus/client_java#1548

Bumps [io.prometheus:prometheus-metrics-bom](https://github.com/prometheus/client_java) from 1.3.10 to 1.4.1.
- [Release notes](https://github.com/prometheus/client_java/releases)
- [Commits](prometheus/client_java@v1.3.10...v1.4.1)

---
updated-dependencies:
- dependency-name: io.prometheus:prometheus-metrics-bom
  dependency-version: 1.4.1
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/gradle/main/io.prometheus-prometheus-metrics-bom-1.4.1 branch from a984eb4 to 10ff165 Compare September 3, 2025 17:21
@github-actions github-actions bot merged commit a94d4bb into main Sep 9, 2025
13 checks passed
@dependabot dependabot bot deleted the dependabot/gradle/main/io.prometheus-prometheus-metrics-bom-1.4.1 branch September 9, 2025 06:16
@spring-builds spring-builds modified the milestones: 1.16.x, 1.16.0-M3 Sep 9, 2025
@shakuzen
Copy link
Member

shakuzen commented Sep 9, 2025

I've updated our tests for the new behavior in the meantime so this upgrade is included in the M3 release. We can continue to follow-up on this before the 1.16.0 GA release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file java Pull requests that update Java code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants