[Spec] Table element#5806
Merged
Merged
Conversation
golddove
requested review from
RebeccaAnne,
almedina-ms,
dclaux,
jonmill,
jwoo-msft,
matthidinger and
paulcam206
May 10, 2021 17:05
dclaux
approved these changes
May 10, 2021
Merged
paulcam206
requested changes
May 10, 2021
ghost
added
the
paulcam206
approved these changes
May 13, 2021
jwoo-msft
requested changes
May 14, 2021
jwoo-msft
approved these changes
May 18, 2021
paulcam206
requested changes
May 18, 2021
|
|
||
| As a descendent of `Container`, `TableCell` can contain any Adaptive Card element, including ColumnSet or even other Table elements. | ||
|
|
||
| ### HostConfig changes |
Member
There was a problem hiding this comment.
this section doesn't mention the cellSpacing changes from the Notes on rendering Table above
Member
Author
There was a problem hiding this comment.
Looks like it was at the top. Moved it down, and added the json.
golddove
enabled auto-merge (squash)
May 21, 2021 16:50
paulcam206
approved these changes
May 21, 2021
michaelfarnsworth
pushed a commit
to michaelfarnsworth/AdaptiveCards
that referenced
this pull request
Nov 10, 2022
* Move issue description to file * Remove JS links * Rename ColumnDefinition to TableColumnDefinition * Fix typos * cellSpacing * Typo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Fixes #5630
Description
Moved @dclaux's excellent spec from the issue description to a file, for sign-off and discussing any remaining concerns.
Microsoft Reviewers: Open in CodeFlow