[UWP]: Update ObjectModelProjection.vcxproj to have control flow guard - #6729
Merged
Merged
Conversation
Add control guard on all flavors of binaries
paulcam206
approved these changes
Nov 12, 2021
paulcam206
left a comment
paulcam206
left a comment
Member
There was a problem hiding this comment.
awesome - thanks for this!
@jonmill 👀
licanhua
reviewed
Nov 12, 2021
beervoley
changed the title
Member
|
@licanhua - can you take another look? thanks! :) |
paulcam206
enabled auto-merge (squash)
November 12, 2021 20:16
licanhua
approved these changes
Nov 12, 2021
paulcam206
pushed a commit
that referenced
this pull request
Nov 16, 2021
#6729) * Update ObjectModelProjection.vcxproj Add control guard on all flavors of binaries * Update ObjectModelProjection.vcxproj
paulcam206
added a commit
that referenced
this pull request
Apr 27, 2022
* [Infrastructure] Disable failing push job from js-release.yml (#6563) Disable push job from js-release.yml to be able to continue package release * [UWP][Infra] Update nuget files for release (#6576) * Add new nuspec files * Fix nuspec * Update build copy script * Add dependency to renderer * 1.5 website schema explorer updates (#6550) * Updating schema explorer properties * adding tableCell to toc and attempting whitespace fix * indentation fix indentation fix * Removing filtered prop Removing filtered prop - it's auto generated in our build Co-authored-by: RahulAmlekar <raamleka@microsoft.com> * Custom.props to 1.0.0 for Object model build * Update dependency version Co-authored-by: Rahul Amlekar <rahul.amlekar@mail.mcgill.ca> Co-authored-by: RahulAmlekar <raamleka@microsoft.com> Co-authored-by: Rebecca Muraira <rebecch@microsoft.com> * Changed pod to source form (#6582) (#6586) * changed pod to source form * moved c++ and objc++ headers to private * Added resource bundle * Added excluded files list This reverts commit 2cd4d4d. * updated verison in spec * corrected the version * tag for ios release * Fixed Header files in Unit tests & fixed warnings * [Infrastructure][.NET] Update public key location for signing (#6589) * Update public key name * Fix name * Test path * Test path * Test path * Test path * Test path * Test path * Update key to right key * Updated min supported iOS version (#6593) * updated supported min version to iOS 12 * updated podspec * updated symlinks * [UWP]: Update ObjectModelProjection.vcxproj to have control flow guard (#6729) * Update ObjectModelProjection.vcxproj Add control guard on all flavors of binaries * Update ObjectModelProjection.vcxproj * [UWP] Update custom.props version for cfguard patch release * [UWP]: Don't use AdaptiveImage to render BackgroundImage (#6838) * increment version * bring up to master * update rendering nuspec * update rendering nuspec * remove deprecated html renderer Co-authored-by: almedina-ms <35784165+almedina-ms@users.noreply.github.com> Co-authored-by: Rahul Amlekar <rahul.amlekar@mail.mcgill.ca> Co-authored-by: RahulAmlekar <raamleka@microsoft.com> Co-authored-by: Rebecca Muraira <rebecch@microsoft.com> Co-authored-by: Joseph Woo <Joseph.Woo@microsoft.com> Co-authored-by: Nassim Amar <namar0x0309@users.noreply.github.com> Co-authored-by: Paul Campbell (DEP) <paulcam@microsoft.com>
michaelfarnsworth
pushed a commit
to michaelfarnsworth/AdaptiveCards
that referenced
this pull request
Nov 10, 2022
microsoft#6729) * Update ObjectModelProjection.vcxproj Add control guard on all flavors of binaries * Update ObjectModelProjection.vcxproj
michaelfarnsworth
pushed a commit
to michaelfarnsworth/AdaptiveCards
that referenced
this pull request
Nov 10, 2022
* [Infrastructure] Disable failing push job from js-release.yml (microsoft#6563) Disable push job from js-release.yml to be able to continue package release * [UWP][Infra] Update nuget files for release (microsoft#6576) * Add new nuspec files * Fix nuspec * Update build copy script * Add dependency to renderer * 1.5 website schema explorer updates (microsoft#6550) * Updating schema explorer properties * adding tableCell to toc and attempting whitespace fix * indentation fix indentation fix * Removing filtered prop Removing filtered prop - it's auto generated in our build Co-authored-by: RahulAmlekar <raamleka@microsoft.com> * Custom.props to 1.0.0 for Object model build * Update dependency version Co-authored-by: Rahul Amlekar <rahul.amlekar@mail.mcgill.ca> Co-authored-by: RahulAmlekar <raamleka@microsoft.com> Co-authored-by: Rebecca Muraira <rebecch@microsoft.com> * Changed pod to source form (microsoft#6582) (microsoft#6586) * changed pod to source form * moved c++ and objc++ headers to private * Added resource bundle * Added excluded files list This reverts commit 2cd4d4d. * updated verison in spec * corrected the version * tag for ios release * Fixed Header files in Unit tests & fixed warnings * [Infrastructure][.NET] Update public key location for signing (microsoft#6589) * Update public key name * Fix name * Test path * Test path * Test path * Test path * Test path * Test path * Update key to right key * Updated min supported iOS version (microsoft#6593) * updated supported min version to iOS 12 * updated podspec * updated symlinks * [UWP]: Update ObjectModelProjection.vcxproj to have control flow guard (microsoft#6729) * Update ObjectModelProjection.vcxproj Add control guard on all flavors of binaries * Update ObjectModelProjection.vcxproj * [UWP] Update custom.props version for cfguard patch release * [UWP]: Don't use AdaptiveImage to render BackgroundImage (microsoft#6838) * increment version * bring up to master * update rendering nuspec * update rendering nuspec * remove deprecated html renderer Co-authored-by: almedina-ms <35784165+almedina-ms@users.noreply.github.com> Co-authored-by: Rahul Amlekar <rahul.amlekar@mail.mcgill.ca> Co-authored-by: RahulAmlekar <raamleka@microsoft.com> Co-authored-by: Rebecca Muraira <rebecch@microsoft.com> Co-authored-by: Joseph Woo <Joseph.Woo@microsoft.com> Co-authored-by: Nassim Amar <namar0x0309@users.noreply.github.com> Co-authored-by: Paul Campbell (DEP) <paulcam@microsoft.com>
rankush
pushed a commit
to rankush/AdaptiveCards
that referenced
this pull request
May 8, 2024
* [Infrastructure] Disable failing push job from js-release.yml (microsoft#6563) Disable push job from js-release.yml to be able to continue package release * [UWP][Infra] Update nuget files for release (microsoft#6576) * Add new nuspec files * Fix nuspec * Update build copy script * Add dependency to renderer * 1.5 website schema explorer updates (microsoft#6550) * Updating schema explorer properties * adding tableCell to toc and attempting whitespace fix * indentation fix indentation fix * Removing filtered prop Removing filtered prop - it's auto generated in our build Co-authored-by: RahulAmlekar <raamleka@microsoft.com> * Custom.props to 1.0.0 for Object model build * Update dependency version Co-authored-by: Rahul Amlekar <rahul.amlekar@mail.mcgill.ca> Co-authored-by: RahulAmlekar <raamleka@microsoft.com> Co-authored-by: Rebecca Muraira <rebecch@microsoft.com> * Changed pod to source form (microsoft#6582) (microsoft#6586) * changed pod to source form * moved c++ and objc++ headers to private * Added resource bundle * Added excluded files list This reverts commit 2cd4d4d. * updated verison in spec * corrected the version * tag for ios release * Fixed Header files in Unit tests & fixed warnings * [Infrastructure][.NET] Update public key location for signing (microsoft#6589) * Update public key name * Fix name * Test path * Test path * Test path * Test path * Test path * Test path * Update key to right key * Updated min supported iOS version (microsoft#6593) * updated supported min version to iOS 12 * updated podspec * updated symlinks * [UWP]: Update ObjectModelProjection.vcxproj to have control flow guard (microsoft#6729) * Update ObjectModelProjection.vcxproj Add control guard on all flavors of binaries * Update ObjectModelProjection.vcxproj * [UWP] Update custom.props version for cfguard patch release * [UWP]: Don't use AdaptiveImage to render BackgroundImage (microsoft#6838) * increment version * bring up to master * update rendering nuspec * update rendering nuspec * remove deprecated html renderer Co-authored-by: almedina-ms <35784165+almedina-ms@users.noreply.github.com> Co-authored-by: Rahul Amlekar <rahul.amlekar@mail.mcgill.ca> Co-authored-by: RahulAmlekar <raamleka@microsoft.com> Co-authored-by: Rebecca Muraira <rebecch@microsoft.com> Co-authored-by: Joseph Woo <Joseph.Woo@microsoft.com> Co-authored-by: Nassim Amar <namar0x0309@users.noreply.github.com> Co-authored-by: Paul Campbell (DEP) <paulcam@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add control guard on all flavors of binaries
Related Issue
Fixes #6730
NOTE: For multiple issues resolved by this PR use the corresponding keywords every time in a comma-delimited list per the reference
page above.
Description
Enable control flow guard on ObjectModelProject.vcxproj
Sample Card
If appropriate, please include a link to a card in one of the samples directories that can be used to validate this change. This can be an existing card or a card added with this PR.
How Verified
- Build Solution in for all platforms
Microsoft Reviewers: Open in CodeFlow