Skip to content

[UWP Renderer] Add a null check to requirements in MeetsRequirements - #8235

Merged
anna-dingler merged 9 commits into
mainfrom
anna/utilNullCheck
Feb 27, 2023
Merged

[UWP Renderer] Add a null check to requirements in MeetsRequirements#8235
anna-dingler merged 9 commits into
mainfrom
anna/utilNullCheck

Conversation

@anna-dingler

@anna-dingler anna-dingler commented Jan 17, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Related Issue

Fixes #8325

Description

Added a null check to requirements for when MeetsRequirements is called by a custom input.

Without the check, we were getting an Access Violation error.

Sample Card

https://github.com/microsoft/AdaptiveCards/blob/main/samples/v1.3/Tests/customInput.json

How Verified

Verified manually on the AdaptiveCards Visualizer.

Microsoft Reviewers: Open in CodeFlow

anna-dingler and others added 5 commits December 16, 2022 00:41
@anna-dingler
Switch to gotFocus (#8148) (#8150)
1e0f72a
@jwoo-msft
Update custom.props
61db685
@anna-dingler @jwoo-msft
[UWP] Update custom.props for object model release (#8225)
0593d95 
* Update custom.props for object model release

* Updated Xcode version (#8222)

* removed build step as they are redundant (#8201)

* removed build step as they are redundant

* added pod installation step

Co-authored-by: Joseph Woo <Joseph.Woo@microsoft.com>
@anna-dingler @jwoo-msft
[UWP Renderer] Add a null check to inline action rendering (#8228)
90b97be 
* Update custom.props for object model release

* Updated Xcode version (#8222)

* removed build step as they are redundant (#8201)

* removed build step as they are redundant

* added pod installation step

* Add a null check for inline Actions

Co-authored-by: Joseph Woo <Joseph.Woo@microsoft.com>
@anna-dingler
Add null check to MeetsRequirements
415b5fe
@ghost ghost added the no-recent-activity label Jan 22, 2023
@ghost

ghost commented Jan 22, 2023

Copy link
Copy Markdown

Hi @anna-dingler. This pull request has had no recent activity for the past 5 days . Please take the necessary actions (review, address feedback or commit if reviewed already) to move this along.

beervoley
beervoley reviewed Jan 23, 2023
View reviewed changes
Comment thread source/uwp/Renderer/lib/Util.cpp Outdated
beervoley
beervoley reviewed Jan 23, 2023
View reviewed changes
Comment thread source/uwp/Renderer/lib/Util.cpp
@anna-dingler
anna-dingler changed the base branch from release/uwp-v3.1.0 to main February 22, 2023 17:14
@microsoft-github-policy-service

microsoft-github-policy-service Bot commented Feb 22, 2023

Copy link
Copy Markdown
Contributor

Staleness reset by anna-dingler

beervoley
beervoley reviewed Feb 24, 2023
View reviewed changes
Comment thread source/uwp/SharedRenderer/lib/Util.cpp
@anna-dingler
anna-dingler merged commit ee62bd3 into main Feb 27, 2023
@anna-dingler
anna-dingler deleted the anna/utilNullCheck branch February 27, 2023 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@beervoley beervoley beervoley approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[UWP Renderer] Access Violation error for Custom Inputs

3 participants

@anna-dingler @beervoley @jwoo-msft