Skip to content

Fix ros2 compilation warnings #4532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zimmy87 merged 2 commits into from
Jun 1, 2022
Merged

Fix ros2 compilation warnings #4532

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
94c6aa1
fix -Wformat warnings
alonfaraj May 19, 2022
c8241d1
fix deprecated rclcpp:::Duration warning
alonfaraj May 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions ros2/src/airsim_ros_pkgs/src/airsim_ros_wrapper.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ void AirsimROSWrapper::initialize_airsim()
}
catch (rpc::rpc_error& e) {
std::string msg = e.get_error().as<std::string>();
RCLCPP_ERROR(nh_->get_logger(), "Exception raised by the API, something went wrong.\n%s", msg);
RCLCPP_ERROR(nh_->get_logger(), "Exception raised by the API, something went wrong.\n%s", msg.c_str());
rclcpp::shutdown();
}
}
Expand Down Expand Up @@ -682,7 +682,7 @@ sensor_msgs::msg::PointCloud2 AirsimROSWrapper::get_lidar_msg_from_airsim(const
if (isENU_) {
try {
sensor_msgs::msg::PointCloud2 lidar_msg_enu;
auto transformStampedENU = tf_buffer_->lookupTransform(AIRSIM_FRAME_ID, vehicle_name, rclcpp::Time(0), rclcpp::Duration(1));
auto transformStampedENU = tf_buffer_->lookupTransform(AIRSIM_FRAME_ID, vehicle_name, rclcpp::Time(0), rclcpp::Duration::from_nanoseconds(1));
tf2::doTransform(lidar_msg, lidar_msg_enu, transformStampedENU);

lidar_msg_enu.header.stamp = lidar_msg.header.stamp;
Expand Down Expand Up @@ -925,7 +925,7 @@ void AirsimROSWrapper::drone_state_timer_cb()
}
catch (rpc::rpc_error& e) {
std::string msg = e.get_error().as<std::string>();
RCLCPP_ERROR(nh_->get_logger(), "Exception raised by the API:\n%s", msg);
RCLCPP_ERROR(nh_->get_logger(), "Exception raised by the API:\n%s", msg.c_str());
}
}

Expand Down Expand Up @@ -1234,7 +1234,7 @@ void AirsimROSWrapper::img_response_timer_cb()

catch (rpc::rpc_error& e) {
std::string msg = e.get_error().as<std::string>();
RCLCPP_ERROR(nh_->get_logger(), "Exception raised by the API, didn't get image response.\n%s", msg);
RCLCPP_ERROR(nh_->get_logger(), "Exception raised by the API, didn't get image response.\n%s", msg.c_str());
}
}

Expand All @@ -1253,7 +1253,7 @@ void AirsimROSWrapper::lidar_timer_cb()
}
catch (rpc::rpc_error& e) {
std::string msg = e.get_error().as<std::string>();
RCLCPP_ERROR(nh_->get_logger(), "Exception raised by the API, didn't get image response.\n%s", msg);
RCLCPP_ERROR(nh_->get_logger(), "Exception raised by the API, didn't get image response.\n%s", msg.c_str());
}
}

Expand Down