Triage seed knowledge and document admission test for preview#5
Merged
Conversation
Remove seven knowledge files whose content is generic software-engineering guidance that a capable LLM already applies without BCQuality present (HTTPS-only, secret-leakage-in-errors, no-credentials-in-URLs, silent security-error swallowing, short transaction scope, HTTP timeouts, StrSubstNo-vs-concatenation). These fail the remedial-knowledge premise and dilute the signal of the preview corpus. Strip the "Seed article — domain stewards should expand" banner from ten files that are ready to showcase (AA0232/AA0233 rules, FindSet read-only semantics, SetLoadFields ordering and usage, CalcFields-in-loops, SecretText end-to-end, DataClassification). The banner remains on files that still need domain-steward refinement. Add a "What belongs here" section to the README stating the admission test: a file exists only if a modern LLM would get something wrong or miss something without it. Gives contributors a concrete yes/no filter before they open a PR.
Most of the corpus — FindSet/SetLoadFields/CalcFields patterns, permission sets, SingleInstance codeunits, DataClassification, IsolatedStorage, transaction scope, SecretText — describes BC platform behaviour that is identical across supported versions. The seed [26..28] range on every file implied a version-specificity the content does not actually have, and there was no way to express "applies to every version" in the schema the way [w1] and [all] already do for countries and application-area. Extend the v1 schema with a universal sentinel for bc-version, parallel to the sentinels already defined for the other dimensions: bc-version: [all] # applies to every BC version [all] is mutually exclusive with explicit versions. Range shorthand ([26..28]) and explicit lists ([26, 27, 28]) continue to work for files genuinely tied to a version-gated API or deprecation. Update read.md (field definition, matching semantics, partial-context rule), write.md (default to [all], use ranges only with a concrete reason), README.md (frontmatter example), and the CI validator. All forty existing knowledge files and the three action skills convert to [all]; none of the current content is version-gated. Validator passes.
This was referenced Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Preparing the repo for the community preview announcement next week. Two changes:
Delete seven knowledge files that fail the remedial-knowledge premise. BCQuality exists to capture things a capable LLM would get wrong or miss without it. These seven seed articles encode generic software-engineering guidance that modern LLMs already apply without BCQuality present:
performance/use-strsubstno-for-message-formatting— "don't concatenate, use a format function"performance/keep-transaction-scope-short— generic transactional advice; the BC-specific nuance lives in the sibling articles (avoid-commit-inside-loops,avoid-user-interaction-in-transactions)security/avoid-sensitive-data-in-error-messages— OWASP genericssecurity/do-not-put-credentials-in-urls— OWASP genericssecurity/do-not-swallow-security-errors-silently— "log your errors"security/require-https-for-external-calls— "use HTTPS"security/set-timeouts-for-external-calls— "set a timeout"Verified no inbound references from other knowledge files before deletion.
Strip the "Seed article — domain stewards should expand" banner from ten showcase-grade files whose content is ready for a preview audience: AA0232/AA0233 rules, FindSet read-only semantics, SetLoadFields ordering and usage, CalcFields-in-loops, SecretText end-to-end, DataClassification. The banner remains on the other seed articles that still need steward refinement.
Add a "What belongs here" section to the README stating the admission test explicitly:
Gives contributors a concrete yes/no filter before they open a PR, and frames the preview corpus as intentionally narrow rather than incomplete.
Test plan