Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Fluent/Copilot typing indicator “sliding dots” asset to remove the unwanted white background and adds a reduced-motion variant to avoid imperative SVG animation control.
Changes:
- Added a reduced-motion “sliding dots” asset entry and wiring to select it when
prefers-reduced-motionis active. - Simplified the
SlidingDotscomponent to render as an<img>instead of an<object>with SVG DOM control. - Updated/expanded HTML-based typing indicator tests to support Fluent/Copilot dark theme scenarios and React 18 module loading.
Reviewed changes
Copilot reviewed 8 out of 12 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/test/test-assets/entry/@fluentui/tokens.js | Exports webDarkTheme for test pages that need Fluent dark theme tokens. |
| packages/fluent-theme/src/components/assets/SlidingDots.tsx | Switches to <img> and selects a reduced-motion asset by name. |
| packages/fluent-theme/src/components/assets/AssetName.ts | Adds a new asset name for reduced-motion sliding dots. |
| packages/fluent-theme/src/components/assets/AssetComposer.tsx | Generates and registers a reduced-motion SVG blob URL alongside the existing sliding dots asset. |
| tests/html2/typing/typingIndicator.scroll.html | Migrates test page setup to React 18/module import maps and adds Fluent theme + color-scheme emulation support. |
| tests/html2/typing/typingIndicator.scroll.fluent.dark.html | Adds a redirecting test fixture for Fluent dark theme. |
| tests/html2/typing/typingIndicator.scroll.copilot.dark.html | Adds a redirecting test fixture for Copilot (Fluent variant) dark theme. |
| CHANGELOG.md | Adds changelog entry for the typing indicator background color fix. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
compulim
approved these changes
Mar 5, 2026
Contributor
compulim
left a comment
There was a problem hiding this comment.
I love the idea of reduced-motion in asset name. I was puzzled abit about the replaceAll but it makes sense.
OEvgeny
added a commit
that referenced
this pull request
Mar 5, 2026
* fix: sliding dots have white background * Productionalize * Add free tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Entry
Description
This removes fluent/copilot sliding dots animation background so it always look neat independent of the page background.
Design
Produce asset which is frozen instead of using imperative SVG APIs.
Specific Changes
Added new asset and asset name
Used the asset when reduced motion preference is active
CHANGELOG.mdI have updated documentationReview Checklist
z-index)package.jsonandpackage-lock.jsonreviewed