Skip to content

WIP: Allow explicit group status#5773

Draft
OEvgeny wants to merge 2 commits intomainfrom
feat/respect-group-status
Draft

WIP: Allow explicit group status#5773
OEvgeny wants to merge 2 commits intomainfrom
feat/respect-group-status

Conversation

@OEvgeny
Copy link
Collaborator

@OEvgeny OEvgeny commented Mar 7, 2026

Fixes #

Changelog Entry

Description

Design

Specific Changes

  • I have added tests and executed them locally
  • I have updated CHANGELOG.md
  • I have updated documentation

Review Checklist

This section is for contributors to review your work.

  • Accessibility reviewed (tab order, content readability, alt text, color contrast)
  • Browser and platform compatibilities reviewed
  • CSS styles reviewed (minimal rules, no z-index)
  • Documents reviewed (docs, samples, live demo)
  • Internationalization reviewed (strings, unit formatting)
  • package.json and package-lock.json reviewed
  • Security reviewed (no data URIs, check for nonce leak)
  • Tests reviewed (coverage, legitimacy)

);

const currentGroupStatus = currentMessage?.creativeWorkStatus || defaultWorkStatus;
// Group status resolution:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love your rationale over here.

Comment on lines +186 to +192
const [howToStatus, howToAbstract] = useMemo(
() => [
messages.find(message => message.isPartOf?.creativeWorkStatus)?.isPartOf?.creativeWorkStatus,
messages.find(message => message.isPartOf?.creativeWorkStatus)?.isPartOf?.abstract
],
[messages]
);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpicking.

Suggested change
const [howToStatus, howToAbstract] = useMemo(
() => [
messages.find(message => message.isPartOf?.creativeWorkStatus)?.isPartOf?.creativeWorkStatus,
messages.find(message => message.isPartOf?.creativeWorkStatus)?.isPartOf?.abstract
],
[messages]
);
const [howToAbstract, howToStatus] = useMemo(
() => [
messages.find(message => message.isPartOf?.creativeWorkStatus)?.isPartOf?.abstract,
messages.find(message => message.isPartOf?.creativeWorkStatus)?.isPartOf?.creativeWorkStatus
],
[messages]
);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants