[CFUFirmwareSimulation] Remove DMF_CONFIG_VirtualHidDeviceVhf HidDescriptor(Length) assignment#62
Open
forderud wants to merge 1 commit into
Open
[CFUFirmwareSimulation] Remove DMF_CONFIG_VirtualHidDeviceVhf HidDescriptor(Length) assignment#62forderud wants to merge 1 commit into
forderud wants to merge 1 commit into
Conversation
Also, remove g_CfuVirtualHid_HidDescriptor that is no longer used anywhere. This is a compatibility change to become compatible with more recent DMF versions where these fields have been removed. Please note that the HidReportDescriptor(Length) fields are still set. It's only the HID descriptor above that is removed. The currently used version v1.1.29 of the DMF library sources doesn't seem to be using the HidDescriptor(Length) fields for anything. This is therefore basically dead code removal that shouldn't cause any problems with the current DMF version used.
forderud
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also, remove
g_CfuVirtualHid_HidDescriptorthat is no longer used anywhere. This is a compatibility change to become compatible with more recent DMF versions where these fields have been removed (see microsoft/DMF#196). Please note that theHidReportDescriptor(Length)fields are still set. It's only the HID descriptor above that is removed.The currently used version v1.1.29 of the DMF library sources doesn't seem to be using the
HidDescriptor(Length)fields for anything. This is therefore basically dead code removal that shouldn't cause any problems with the current DMF version used.