Tactical mem leak fix for aggregation - #673
Closed
Scott Jones (Scottj1s) wants to merge 4 commits into
Closed
Conversation
Scott Jones (Scottj1s)
requested review from
Aaron R Robinson (AaronRobinsonMSFT) and
Manodasan Wignarajah (manodasanW)
January 17, 2021 00:52
Aaron R Robinson (AaronRobinsonMSFT)
left a comment
Aaron R Robinson (AaronRobinsonMSFT)
left a comment
Member
There was a problem hiding this comment.
Cursory comments - will look in more detail next week.
|
|
||
| // Manual for now - verify that all APIs targeting 19041 generate a warning | ||
| // Consider invoking roslyn and scraping/analyzing output as an automated test | ||
| private void Test() |
There was a problem hiding this comment.
Not a feedback for this PR, but as an FYI, we can probably automate this test this by creating a C# compilation context and triggering a compilation on it and then checking for diagnostics. An example of this is the diagnostics test which Joshua wrote which do this.
Member
Author
There was a problem hiding this comment.
Feel free to open an issue with specific suggestion
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My main concern with this technique is that when _inner is disposed before its owner is finalized, the finalizer has no chance to detach and the refcount is too low by 1. Since finalizers can run on any thread, in any order, I'm not confident that keeping the inner refcount artificially low is a reliable fix here. In fact, I think any approach that tries to do so is doomed. There's just no safe way to defer an AddRef while still holding onto a COM pointer - it's a time bomb.