Internal validator error messages don't need /Zi anymore.#3606
Conversation
pow2clk
left a comment
pow2clk
left a comment
There was a problem hiding this comment.
I really like the look of these changes. I'm impressed it didn't take more invasive changes than this.
You refer to tests that have errors referencing Zi. Do you mean to remove the suggestion to add Zi from those error messages? That would be great. Sadly, we sometimes emit them even when they don't make any difference in the ability to print line numbers 😯
|
❌ Build DirectXShaderCompiler 1.0.4613 failed (commit 066d40e5df by @adam-hby) |
Yeah I want to test that we actually print out the line numbers correctly even withou Zi. Which cases does Zi not help? Maybe this change would fix it. |
|
I fixed the case I remember clearly, but I have a vague recollection that it's sometimes the case. |
|
The case I remember was trying to print the line number of an input variable that just didn't have one debug or no. It's possible that crops up in other areas. Irritating as an error message that gives no location information is, I think it's more irritating to be prompted to add a Zi flag when 1) you have or 2) you try it and it doesn't help 😞 |
adam-yang
changed the title
|
❌ Build DirectXShaderCompiler 1.0.4624 failed (commit becb128dd8 by @adam-hby) |
|
❌ Build DirectXShaderCompiler 1.0.4625 failed (commit a16d9d31aa by @tex3d) |
| std::unique_ptr<llvm::MemoryBuffer> pMemBuf; | ||
| LLVMContext ctx; | ||
| if (pDebugModule) { | ||
| pMemBuf = llvm::MemoryBuffer::getMemBuffer(StringRef((char *)pDebugModule->Ptr, pDebugModule->Size), "", false); |
There was a problem hiding this comment.
As the clang error implies, this will need to be cast to (const char*) with that change, it builds with clang
There was a problem hiding this comment.
Yes, and that reminds me about other issues which make it necessary to refactor this a bit more in any case.
|
❌ Build DirectXShaderCompiler 1.0.4631 failed (commit c8dc883bb1 by @tex3d) |
tex3d
left a comment
tex3d
left a comment
There was a problem hiding this comment.
I think this is good now if it passes CI.
|
✅ Build DirectXShaderCompiler 1.0.4633 completed (commit 46263aee30 by @tex3d) |
5 participants
No description provided.