[SPIRV] Get alignemnt from pointee type for vk::BufferPoitner store#7501
Merged
Conversation
A small mistake for stores to vk:BufferPointer when storing directly to the return value of `get()`. We were getting the alignment of the pointer itself, which is always 8 instead of the type pointed to. I tested loads, and it does not have the same problem. Fixes microsoft#7459
Keenuts
approved these changes
Jun 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A small mistake for stores to vk:BufferPointer when storing directly to
the return value of
get(). We were getting the alignment of thepointer itself, which is always 8 instead of the type pointed to.
I tested loads, and it does not have the same problem.
Fixes #7459