[spirv] Corrects output node index parameter.#7517
Merged
Conversation
Contributor
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
danbrown-amd
force-pushed
the
node-index-fix
branch
2 times, most recently
from
b80edf7 to
683c961
Compare
danbrown-amd
force-pushed
the
node-index-fix
branch
from
683c961 to
00575df
Compare
s-perron
approved these changes
Jun 6, 2025
Collaborator
|
This LGTM, but I'm not very familiar with how the work graphs are suppose to work. I'm going to trust you for that. I'll merge when you tell me it is ready to be merged. |
Contributor
Author
|
It's good to go. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The node index parameter of
OpAllocateNodePayloadsAMDXwas being set to the value of the NodeId index argument (which is captured in thePayloadNodeBaseIndexAMDXdecoration). Instead, it should be set to the node's index in the node array, if any, or zero for a single node.