[SPIRV] Use unknown image format in vk1.3 and later#7528
Merged
Conversation
We have had many request to use the `unknown` image format for storage images (OpTypeImage with sampled=2). We did not want to do that when targeting earlier versions of Vulkan because it could break existing code. The capability StorageImageWriteWithoutFormat is not guarenteed to be available on Vulkan 1.1 devices. This means the application will stop working. However, Vulkan 1.3 guarentees that StorageImageWriteWithoutFormat and StorageImageReadWithoutFormat are available. We can make this change for VK1.3 and later without breaking existing code. Fixes microsoft#7478
Keenuts
approved these changes
Jun 12, 2025
bogner
approved these changes
Jun 12, 2025
Keenuts
approved these changes
Jun 13, 2025
s-perron
added a commit
that referenced
this pull request
Jun 24, 2025
I just learned more about the VK feature. In VK1.3, the validation rule was moved from the existence of the capability to being specific to the format. It is possible that people will see regressions if their code runs on a driver that does not support VK_FORMAT_FEATURE_2_STORAGE_WRITE_WITHOUT_FORMAT_BIT or VK_FORMAT_FEATURE_2_STORAGE_READ_WITHOUT_FORMAT_BIT for the format used by the developer. Reverts #7528
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have had many request to use the
unknownimage format for storageimages (OpTypeImage with sampled=2). We did not want to do that when
targeting earlier versions of Vulkan because it could break existing
code. The capability StorageImageWriteWithoutFormat is not guarenteed to
be available on Vulkan 1.1 devices. This means the application will stop
working.
However, Vulkan 1.3 guarentees that StorageImageWriteWithoutFormat and
StorageImageReadWithoutFormat are available. We can make this change for
VK1.3 and later without breaking existing code.
Fixes #7484