PIX: Report correct bitfield values in PIX shader debugger

[jeffnn]

The key change here is the & in DxcDxilPixStorage.cpp. The generated DXIL packs the bitfields into their 32- or 64-bit-typed Values as expected, but this code, when trying to figure out which Value a bitfield lives in, was looking up the unpacked bit offset, so only fields within the zeroth underlying Value were being reported correctly.

With this change, PIX reports correct bitfield values wherever they live, including within deeply nested structs.

Unfortunately, the tests had to be in C++ because file-check obv. doesn't run the APIs that PIX uses to read debug data.

[github-actions]

⚠️ C/C++ code formatter, clang-format found issues in your code. ⚠️

You can test this locally with the following command:

git-clang-format --diff 5aec1ec4e4d0e31a263f24458c598a3b151c0d4f 292b4ae4e36be49cdb8ffa5227e84b07890f31ed -- lib/DxilDia/DxcPixDxilStorage.cpp tools/clang/unittests/HLSL/PixDiaTest.cpp

View the diff from clang-format here.

diff --git a/tools/clang/unittests/HLSL/PixDiaTest.cpp b/tools/clang/unittests/HLSL/PixDiaTest.cpp
index 21162226..d36e7627 100644
--- a/tools/clang/unittests/HLSL/PixDiaTest.cpp
+++ b/tools/clang/unittests/HLSL/PixDiaTest.cpp
@@ -2789,7 +2789,7 @@ public:
   DxcIncludeHandlerForInjectedSourcesForPix(
       PixDiaTest *pixTest,
       std::vector<std::pair<std::wstring, std::string>> files)
-      : m_dwRef(0), m_files(files), m_pixTest(pixTest) {};
+      : m_dwRef(0), m_files(files), m_pixTest(pixTest){};
 
   HRESULT STDMETHODCALLTYPE QueryInterface(REFIID iid,
                                            void **ppvObject) override {

• Check this box to apply formatting changes to this branch.