Execution Tests: HLK - Update for two HLK requirements for SM6.9. Core and double.#8052
Merged
alsepkow merged 2 commits intoJan 13, 2026
Merged
Conversation
Contributor
You can test this locally with the following command:git-clang-format --diff 496974907e2ac7666f8bc889287d174755703016 ff2ad962435ace02a2a21087103adaeda7e54014 -- tools/clang/unittests/HLSLExec/LongVectors.cppView the diff from clang-format here.diff --git a/tools/clang/unittests/HLSLExec/LongVectors.cpp b/tools/clang/unittests/HLSLExec/LongVectors.cpp
index 43ef5ec4..db6258ed 100644
--- a/tools/clang/unittests/HLSLExec/LongVectors.cpp
+++ b/tools/clang/unittests/HLSLExec/LongVectors.cpp
@@ -1796,8 +1796,8 @@ using namespace LongVector;
TEST_METHOD(Op##_##DataType) { \
BEGIN_TEST_METHOD_PROPERTIES() \
TEST_METHOD_PROPERTY( \
- "Kits.Specification", \
- "Device.Graphics.D3D12.DXILCore.ShaderModel69.DoublePrecision") \
+ "Kits.Specification", \
+ "Device.Graphics.D3D12.DXILCore.ShaderModel69.DoublePrecision") \
END_TEST_METHOD_PROPERTIES() \
runTest<DataType, OpType::Op>(); \
}
@@ -1806,8 +1806,8 @@ using namespace LongVector;
TEST_METHOD(Op##_##DataType) { \
BEGIN_TEST_METHOD_PROPERTIES() \
TEST_METHOD_PROPERTY( \
- "Kits.Specification", \
- "Device.Graphics.D3D12.DXILCore.ShaderModel69.CoreRequirement") \
+ "Kits.Specification", \
+ "Device.Graphics.D3D12.DXILCore.ShaderModel69.CoreRequirement") \
END_TEST_METHOD_PROPERTIES() \
runWaveOpTest<DataType, OpType::Op>(); \
}
@@ -1816,8 +1816,8 @@ using namespace LongVector;
TEST_METHOD(Op##_##DataType) { \
BEGIN_TEST_METHOD_PROPERTIES() \
TEST_METHOD_PROPERTY( \
- "Kits.Specification", \
- "Device.Graphics.D3D12.DXILCore.ShaderModel69.DoublePrecision") \
+ "Kits.Specification", \
+ "Device.Graphics.D3D12.DXILCore.ShaderModel69.DoublePrecision") \
END_TEST_METHOD_PROPERTIES() \
runWaveOpTest<DataType, OpType::Op>(); \
}
|
damyanp
approved these changes
Jan 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the tests to recognize an additional HLK requirement for SM6.9 double support as it remains optional for 6.9. 16-bit types, 64-bit integers, and wave ops are required for SM 6.9 so they are implied via the core requirement.
Also removes the priority '2' set on the wave op tests. P2 tests are skipped in our automation. These tests were originally being skipped as WARP did not yet support wave ops with long vectors.
Partially implements #7608 . The rest of the implementation will be handled in OS code.