Execution Tests: Prevent sinking in long vector derivative hlk#8054
Merged
alsepkow merged 2 commits intoJan 13, 2026
Merged
Conversation
tex3d
approved these changes
Jan 13, 2026
Contributor
tex3d
left a comment
tex3d
left a comment
There was a problem hiding this comment.
Though the result of the wave op is unused, it appears that it still prevents ddx from being moved, and the compiler doesn't know it can remove the wave op, so as a workaround, that should be ok for now. It just might be more fragile if the compiler could DCE the wave op in the future, which would be legal.
Contributor
Author
|
I went ahead and updated so we use the result.
…________________________________
From: Tex Riddell ***@***.***>
Sent: Monday, January 12, 2026 4:06 PM
To: microsoft/DirectXShaderCompiler ***@***.***>
Cc: Alex Sepkowski ***@***.***>; Author ***@***.***>
Subject: Re: [microsoft/DirectXShaderCompiler] Execution Tests: Prevent sinking in long vector derivative hlk (PR #8054)
@tex3d approved this pull request.
Though the result of the wave op is unused, it appears that it still prevents ddx from being moved, and the compiler doesn't know it can remove the wave op, so as a workaround, that should be ok for now. It just might be more fragile if the compiler could DCE the wave op in the future, which would be legal.
—
Reply to this email directly, view it on GitHub<#8054 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABK4EWZ2AMWIIQ4ZTW2QDM34GQZHHAVCNFSM6AAAAACRPJYRJOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTMNJTGIYDKOBQHE>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
V-FEXrt
approved these changes
Jan 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a workaround to the hlk long vector derivative tests to prevent sinking of the derivative call into the conditional. This is a known bug in DXC that will not be fixed for 6.9 release.
DXC bug tracked via issue #8001