Fix dxc version printing and fix external validator testing#8075
Merged
Conversation
Contributor
Author
|
Note: there are some follow-up TBDs:
|
bob80905
reviewed
Jan 20, 2026
alsepkow
reviewed
Jan 21, 2026
alsepkow
reviewed
Jan 21, 2026
- No longer skip QI for IDxcVersionInfo2 based on build, since that's for implementer, not user. - Print CustomVersionString from IDxcVersionInfo3 if available. - Remove ifdefs for _WIN32 around file/product version calls, because that's handled in the function. - Only print product version string if available for dxil.dll, since that's what it does for dxcompiler.dll.
I don't think this is necessary anymore.
No point printing some dxil module version if not used. Print it when you set the env var, in which case, the full DXIL path would be printed, so it needs to be less strict about what's immediately before the dxil.dll/libdxil.so name.
10ca117 to
2f159df
Compare
bob80905
reviewed
Jan 21, 2026
This would trigger these tests when targeting test-depends, which isn't desirable.
alsepkow
approved these changes
Jan 22, 2026
bob80905
approved these changes
Jan 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Version print didn't reveal details from available version interfaces, nor did it print file version for DXIL.dll when available. We also weren't testing the external validator we build: (lib)dxil.(dll|so|dylib).
Changes: