Add integration test guarding event-log reducer registration#670
Open
jschick04 wants to merge 1 commit into
Open
Add integration test guarding event-log reducer registration#670jschick04 wants to merge 1 commit into
jschick04 wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new Runtime test that validates Fluxor’s assembly scanning and reducer registration for the EventLogState feature by exercising the reducer pipeline end-to-end (via IFeature<EventLogState>), ensuring regressions like a removed [ReducerMethod] attribute are caught even when existing direct-call reducer tests remain green.
Changes:
- Adds an integration-style test that resolves
IFeature<EventLogState>from a realAddFluxor(...RegisterStateLibrary())container. - Exercises
AddEventActionbuffering (newest-first) andNewEventBufferConsumedActiondraining through the registered reducer path.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jschick04
marked this pull request as ready for review
July 24, 2026 22:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a Runtime.Tests integration test that exercises the real Fluxor reducer registration for the EventLog feature, so a dropped
[ReducerMethod]attribute or a brokenRegisterStateLibrary()assembly scan is caught.Why
The existing
EventLogStoreTestscallReducers.ReduceAddEvent(...)(and the other reducers) directly as static methods, so they stay green even if a reducer is no longer registered with the store - the silent-break class behind live-tail "Load New Events" not rendering. This test resolvesIFeature<EventLogState>from a realAddFluxor(o => o.RegisterStateLibrary())container and appliesAddEventAction+NewEventBufferConsumedActionthrough the registered reducer path (ReceiveDispatchNotificationFromStore), asserting the buffer fills newest-first then drains.Verification
[ReducerMethod]fromReduceAddEventfails this test while the 52 existing direct-call reducer tests stay green (the gap it fills).