Skip to content

Support GoToTargets Request #1102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
WardenGnaw merged 12 commits into from
Jan 29, 2021
Merged

Support GoToTargets Request #1102

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
b874c5c
implement DAP Goto Request
Trass3r Aug 1, 2020
a64c8d5
use List for HandleCollection
Trass3r Sep 9, 2020
1138d4e
use HandleCollection for goto targets
Trass3r Sep 9, 2020
57f5d33
cleanup
Trass3r Sep 11, 2020
9b88764
Revert "use HandleCollection for goto targets"
Trass3r Oct 20, 2020
f119e0c
Fixing todo
WardenGnaw Oct 28, 2020
1ebc16d
add comment about potential race condition
Trass3r Nov 6, 2020
a2558e7
fix exception description so it shows something in vscode
Trass3r Jan 9, 2021
15de662
send "goto" stopped event after sending the command response
Trass3r Jan 9, 2021
f37fe48
Remove Jump for only GoToTarget and add memory ref
WardenGnaw Jan 28, 2021
8fe364a
Addressing PR issues
WardenGnaw Jan 29, 2021
25625cb
Merge branch 'main' into dev/waan/SupportGoToTargets
WardenGnaw Jan 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Addressing PR issues
  • Loading branch information
@WardenGnaw
WardenGnaw committed Jan 29, 2021
commit 8fe364ac26c76a26ab77caff01965d9328d21bd7
10 changes: 6 additions & 4 deletions src/OpenDebugAD7/AD7DebugSession.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -355,7 +355,7 @@ public void BeforeContinue()
m_isStopped = false;
m_variableManager.Reset();
m_frameHandles.Reset();
m_gotoCodeContexts.Clear();
m_gotoCodeContexts.Clear();
}

public void Stopped(IDebugThread2 thread)
Expand Down Expand Up @@ -1326,15 +1326,16 @@ protected override void HandlePauseRequestAsync(IRequestResponder<PauseArguments

protected override void HandleGotoRequestAsync(IRequestResponder<GotoArguments> responder)
{
responder.SetError(new ProtocolException("Not implemented exception."));
responder.SetError(new ProtocolException(AD7Resources.Error_NotImplementedSetNextStatement));
}

protected override void HandleGotoTargetsRequestAsync(IRequestResponder<GotoTargetsArguments, GotoTargetsResponse> responder)
{
var response = new GotoTargetsResponse();

var source = responder.Arguments.Source;
// TODO: handle this for disassembly debugging

// Virtual documents don't have paths
if (source.Path == null)
{
responder.SetResponse(response);
Expand Down Expand Up @@ -1373,7 +1374,8 @@ protected override void HandleGotoTargetsRequestAsync(IRequestResponder<GotoTarg

string instructionPointerReference = null;
CONTEXT_INFO[] contextInfo = new CONTEXT_INFO[1];
if (codeContext.GetInfo(enum_CONTEXT_INFO_FIELDS.CIF_ADDRESS, contextInfo) == HRConstants.S_OK)
if (codeContext.GetInfo(enum_CONTEXT_INFO_FIELDS.CIF_ADDRESS, contextInfo) == HRConstants.S_OK &&
contextInfo[0].dwFields.HasFlag(enum_CONTEXT_INFO_FIELDS.CIF_ADDRESS))
{
instructionPointerReference = contextInfo[0].bstrAddress;
}
Expand Down
28 changes: 18 additions & 10 deletions src/OpenDebugAD7/AD7Resources.Designer.cs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions src/OpenDebugAD7/AD7Resources.resx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,4 +298,7 @@
<data name="Error_Scenario_StackTrace" xml:space="preserve">
<value>Unable to retrieve stack trace. {0}</value>
</data>
<data name="Error_NotImplementedSetNextStatement" xml:space="preserve">
<value>Set next statement is not supported by the current debugger.</value>
</data>
</root>