Skip to content

User Story 1565289: [MIEngine Natvis] Support multiple natvis files in visualizerFile launch configuration #1381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gc46 merged 22 commits into from
Feb 3, 2023
Merged

User Story 1565289: [MIEngine Natvis] Support multiple natvis files in visualizerFile launch configuration #1381

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
4c15504
Multiple Natvis files...hitting NullReferenceException
Jan 13, 2023
75ed8ea
Fix conditional
Jan 13, 2023
2847132
Why is _launchOptions.VisualizerFile null?
Jan 20, 2023
cdf7c72
Handle multiple Natvis files
Jan 20, 2023
2af728d
Clean up code
Jan 20, 2023
23b6627
Tests are failing...
Jan 24, 2023
139ab3d
Fixed new Natvis test
Jan 24, 2023
50400ad
Addressed some PR comments
Jan 25, 2023
1f0e32d
Updating implementation and tests
Jan 26, 2023
2ea8c9c
Addressed some PR comments
Jan 26, 2023
7161bd3
Fix inability to build solution in Windows
Jan 30, 2023
aee38d0
Fix BasicLaunchOptionsTests.cs
Jan 30, 2023
0b09d11
Fixed MICoreUnitTests
Jan 30, 2023
132130e
Disable new test on OS X
Jan 31, 2023
e2e07cc
Clean up TestPurpose
Jan 31, 2023
3cb7931
Initialize Natvis services once
Jan 31, 2023
ee817a3
Addressed PR comments - tests are taking too long to run locally
Feb 1, 2023
9c65634
Fix Android test
Feb 2, 2023
c38f41e
Fix BasicLaunchOptions test
Feb 2, 2023
5b50551
Address PR comments (2/2/2023)
Feb 2, 2023
5a156f8
Address PR comments (2/2/2023)
Feb 3, 2023
cda9d13
Address PR comment
Feb 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix inability to build solution in Windows
  • Loading branch information
Gabrielle Chen committed Jan 30, 2023
commit 7161bd3249cf2c6f59668348cd776b423d8b6714
4 changes: 2 additions & 2 deletions src/AndroidDebugLauncher/Launcher.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -459,8 +459,8 @@ private LaunchOptions SetupForDebuggingWorker(CancellationToken token)

launchOptions.DebuggerMIMode = MIMode.Gdb;

launchOptions.VisualizerFile = new List<string>();
launchOptions.VisualizerFile.Add("Microsoft.Android.natvis");
launchOptions.VisualizerFiles = new List<string>();
launchOptions.VisualizerFiles.Add("Microsoft.Android.natvis");
launchOptions.WaitDynamicLibLoad = _launchOptions.WaitDynamicLibLoad;

return launchOptions;
Expand Down
6 changes: 2 additions & 4 deletions test/CppTests/Tests/NatvisTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -510,6 +510,7 @@ public void TestMultipleNatvisFiles(ITestSettings settings)
{
IFrameInspector currentFrame = threadInspector.Stack.First();

// Simple1.natvis
this.Comment("Verifying ArrayItems natvis");
var ll = currentFrame.GetVariable("vec");
Assert.Equal("{ size=2000 }", ll.Value);
Expand All @@ -521,10 +522,7 @@ public void TestMultipleNatvisFiles(ITestSettings settings)
Assert.Equal("20", ll.GetVariable("[5]").Value);
Assert.Equal("51", ll.GetVariable("[More...]").GetVariable("[51]").Value);

// Multi-dimensional array
var matrix = currentFrame.GetVariable("matrix");
Assert.Equal("3", matrix.GetVariable("[1,1]").Value);

// Simple2.natvis
this.Comment("Verifying TreeItems natvis");
var map = currentFrame.GetVariable("map");

Expand Down