MIEngine: Introduce --thread and --frame options#1401
MIEngine: Introduce --thread and --frame options#1401WardenGnaw merged 2 commits intomicrosoft:mainfrom
Conversation
|
@WardenGnaw Hi Andrew, since -thread-select and -stack-select-frame commands are deprecated in favor of --thread and --frame options respectively, we (at Intel) modified the fork of MI Engine we use for our gdb plugin, which we use with Intel oneAPI. We also wanted to contribute these changes to the upstream MI Engine repository. Could you review the PR and let me know if these changes look good? Please let me know if I am required to report this as an issue and track this in the PR additionally. |
e83b4b5 to
64d6630
Compare
|
@intel-rganesh Thanks for contributing this PR! Do you know if there was a specific version of gdb that |
|
@WardenGnaw Source code of gdb 7.0.0 (Release date: Oct 06, 2009) includes this, and 6.8 does not. Please find the commit details here: If we intend to support really old versions, I can try to fetch the version value from the log and use deprecated thread-select for older versions. |
|
@intel-rganesh I'm not able to see source code of GDB based on its licensing agreements. However, version checks are useful since we do have some embedded engineers who may be using a really old version. |
431d72f to
503df4d
Compare
|
I have amended my commit and used a version check that was recommended. |
WardenGnaw
left a comment
There was a problem hiding this comment.
Sorry for the delay. Just one more comment.
Remove -thread-select and -stack-select-frame and introduce --thread and --frame options instead. It is general recommendation to not use -thread-select and -stack-select-frame and use --thread and --frame instead. More info can be found here: https://sourceware.org/gdb/onlinedocs/gdb/Context-management.html And here are the deprecation notes: -thread-select -thread-select: https://sourceware.org/gdb/onlinedocs/gdb/GDB_002fMI-Thread-Commands.html#GDB_002fMI-Thread-Commands -stack-select-frame -stack-select-frame: https://sourceware.org/gdb/onlinedocs/gdb/GDB_002fMI-Stack-Manipulation.html#GDB_002fMI-Stack-Manipulation Signed-off-by: intel-rganesh rakesh.ganesh@intel.com
503df4d to
b7a764f
Compare
|
@intel-rganesh Thank you for your contribution! We will try to get these changes in the next release as soon as we can. |
Remove -thread-select and -stack-select-frame and introduce --thread and --frame options instead.
It is general recommendation to not use -thread-select and -stack-select-frame and use --thread and --frame instead. More info can be found here:
https://sourceware.org/gdb/onlinedocs/gdb/Context-management.html
And here are the deprecation notes:
-thread-select
-thread-select: https://sourceware.org/gdb/onlinedocs/gdb/GDB_002fMI-Thread-Commands.html#GDB_002fMI-Thread-Commands
-stack-select-frame
-stack-select-frame: https://sourceware.org/gdb/onlinedocs/gdb/GDB_002fMI-Stack-Manipulation.html#GDB_002fMI-Stack-Manipulation
Signed-off-by: intel-rganesh rakesh.ganesh@intel.com