Fix Rank > 1 Display Strings for Natvis#1406
Merged
WardenGnaw merged 3 commits intomainfrom Jul 7, 2023
Merged
Conversation
This PR fixes the display string for ArrayItems with Rank > 1 when the "[More...]" is expanded. Before "[More...]" will expand starting at [0,0] instead of [0,50] for the first expansion since the offsets are at 50.
gregg-miskelly
approved these changes
Jul 7, 2023
mpeyrotc
reviewed
Jul 7, 2023
mpeyrotc
approved these changes
Jul 7, 2023
Co-authored-by: Marco Peyrot <mapeyrot@microsoft.com>
gregg-miskelly
approved these changes
Jul 7, 2023
Member
Author
|
Flaky test failing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the display string for ArrayItems with Rank > 1 when the "[More...]" is expanded.
Before "[More...]" will expand starting at [0,0] instead of [0,50] for the first expansion since the offsets are at 50.
This change updated the call to GetDisplayNameFromArrayIndex from just
indexwhich would always start at 0, tostartIndex + indexto include the offet.Added a test to cover this case and refactored the Matrix Natvis syntax to use rol/col instead of random behavior.
Fixes: #1403