MIEngine: Array evaluation and address check#1427
Merged
WardenGnaw merged 5 commits intomicrosoft:mainfrom Nov 28, 2023
Merged
Conversation
Handle condition where the address is not an AD7MemoryAddress object. On running multiple debug engines, it appears this gets called with a different object type. Signed-off-by: intel-rganesh rakesh.ganesh@intel.com
Allow direct array eval in memory window. Signed-off-by: intel-rganesh rakesh.ganesh@intel.com
WardenGnaw
approved these changes
Nov 27, 2023
gregg-miskelly
requested changes
Nov 28, 2023
Member
gregg-miskelly
left a comment
gregg-miskelly
left a comment
There was a problem hiding this comment.
Looks good aside from those two small issues. Thanks for sending this!
Address review comments for array evaluation and address check: 1> Use the correct constant in AD7Disassembly when pCodeContext is not AD7MemoryAddress. 2> Avoid creating new AD7Property to fetch variable information value. Signed-off-by: intel-rganesh rakesh.ganesh@intel.com
gregg-miskelly
approved these changes
Nov 28, 2023
Member
|
@WardenGnaw have you already investigated what is going on with: |
Member
|
I see. This is what you fixed with #1425. Any reason not to merge that? |
Member
Nope. That PR just got forgotten over the Thanksgiving holidays. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue description & fix:
Issue 1
When the address is not an AD7Memory address, we get a null reference exception while assigning puCodeLocationId.
Fix
The fix is to add a null reference check for this condition.
Issue 2
We would like to evaluate array addresses in Memory View. This was not possible without evaluating without an address operator.
Fix
For variable information value that looks like [], re-evaluate with address operator.
With this change we can evaluate an array address.
Signed-off-by: intel-rganesh rakesh.ganesh@intel.com