Merged
Conversation
gregg-miskelly
requested changes
Nov 28, 2023
Member
gregg-miskelly
left a comment
There was a problem hiding this comment.
Aside from that, this change looks good to me. Thanks for taking the time to submit this!
989a536 to
a2cafc4
Compare
gregg-miskelly
approved these changes
Dec 4, 2023
Member
gregg-miskelly
left a comment
There was a problem hiding this comment.
Thanks for taking the time to submit this!
Member
|
@WardenGnaw do you want to take a quick look also? |
WardenGnaw
approved these changes
Dec 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do reverse sort of the
sourceMap.In my
launch.jsonconfiguration I have the followingsourceFileMap:The YOCTO_ARCH set in
settings.jsonto:The proposed change addresses an issue encountered while debugging a binary that's running on a remote system and built using Yocto. Currently, when debugging, the source files are being referenced from the Yocto build tree instead of the local workspace. This issue prevents setting breakpoints effectively in the local workspace source files.
To resolve this, the change involves modifying the way source mappings are processed. Specifically, it proposes sorting the mappings in reverse order, starting with the longer, more specific paths and moving towards the more general ones. By doing this, the debugger will first consider the project-specific paths defined in
sourceFileMap. If it doesn't find a match there, it will then fall back to the more general paths. This reverse sorting ensures that the local workspace sources are prioritized over the Yocto build tree sources, allowing for effective breakpoint setting and debugging in the local workspace.