MIEngine: Set MajorVersion from the correct place#1441
Merged
WardenGnaw merged 4 commits intomicrosoft:mainfrom Mar 6, 2024
Merged
MIEngine: Set MajorVersion from the correct place#1441WardenGnaw merged 4 commits intomicrosoft:mainfrom
WardenGnaw merged 4 commits intomicrosoft:mainfrom
Conversation
We were previously setting the MajorGdbVersion when the process exited and this was too late. We need to set this OnStateChanged so we can use this to opt for the latest gdb MI commands. Signed-off-by: intel-rganesh rakesh.ganesh@intel.com
Member
Rather than scraping the initialization log after the fact, I think we should just process the line here. Something like: Refers to: src/MICore/Debugger.cs:961 in 46756e5. [](commit_id = 46756e5, deletion_comment = False) |
Try to initialize the gdb version as soon as we add the line to the initialization log. Also, add exception handling when setting major gdb version. Signed-off-by: intel-rganesh rakesh.ganesh@intel.com
iyerrakesh
force-pushed
the
SetMajorVersionCorrectly
branch
from
054b2a4 to
827da1b
Compare
gregg-miskelly
requested changes
Mar 5, 2024
Member
gregg-miskelly
left a comment
gregg-miskelly
left a comment
There was a problem hiding this comment.
Aside from putting back line 495 now, looks good to me.
Clear initialization log as before. Signed-off-by: intel-rganesh rakesh.ganesh@intel.com
gregg-miskelly
approved these changes
Mar 6, 2024
WardenGnaw
approved these changes
Mar 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were previously setting the MajorGdbVersion when the process exited and this was too late.
We need to set this OnStateChanged so we can use this to opt for the latest gdb MI commands.
Additionally include Intel GNU gdb example when fetching the GDB version.
Signed-off-by: intel-rganesh rakesh.ganesh@intel.com