Skip to content

CI Fixups - #994

Merged
bpkroth merged 44 commits into
microsoft:mainfrom
bpkroth:ci-fixups
Oct 22, 2025
Merged

CI Fixups#994
bpkroth merged 44 commits into
microsoft:mainfrom
bpkroth:ci-fixups

Conversation

@bpkroth

@bpkroth bpkroth commented Jul 17, 2025

Copy link
Copy Markdown
Contributor

Pull Request

Title

CI Fixups


Description


Type of Change

  • 🛠️ Bug fix

Testing

CI Pipeline runs again.


Copilot AI review requested due to automatic review settings July 17, 2025 20:14
@bpkroth
bpkroth requested a review from a team as a code owner July 17, 2025 20:14
@bpkroth bpkroth added ready for review Ready for review ci labels Jul 17, 2025

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses a change in the latest version of conda that requires explicit acceptance of terms of service to prevent CI pipeline failures. The changes ensure conda operates in a non-interactive mode suitable for CI environments.

  • Adds CONDA_NO_PROGRESS_BARS=1 environment variable across CI workflows and build configurations
  • Explicitly accepts conda terms of service for required channels in Docker setup
  • Enables debug output (set -x) in Docker build for better troubleshooting

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File Description
Makefile Sets and exports CONDA_NO_PROGRESS_BARS environment variable
.github/workflows/macos.yml Adds CONDA_NO_PROGRESS_BARS=1 to macOS CI environment
.github/workflows/linux.yml Adds CONDA_NO_PROGRESS_BARS=1 to Linux CI environment
.devcontainer/Dockerfile Adds debug output, progress bar suppression, and explicit ToS acceptance for conda channels

Comment thread .devcontainer/Dockerfile Outdated
Comment thread .devcontainer/Dockerfile Outdated
Comment thread .devcontainer/Dockerfile
@bpkroth
bpkroth enabled auto-merge (squash) July 17, 2025 20:47
@bpkroth bpkroth changed the title Accept ToS in Conda CI CI Fixups Sep 18, 2025
@bpkroth bpkroth linked an issue Sep 22, 2025 that may be closed by this pull request
@bpkroth
bpkroth requested a review from motus September 22, 2025 20:22
@bpkroth bpkroth linked an issue Sep 22, 2025 that may be closed by this pull request
Comment thread .devcontainer/scripts/run-devcontainer.sh
Comment thread mlos_bench/mlos_bench/tests/conftest.py
Comment thread mlos_viz/mlos_viz/base.py
Comment thread .github/workflows/devcontainer.yml Outdated

@motus motus left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

Comment thread conda-envs/mlos.yml Outdated
@bpkroth
bpkroth merged commit 1d28aa9 into microsoft:main Oct 22, 2025
31 of 38 checks passed
@bpkroth
bpkroth deleted the ci-fixups branch October 22, 2025 21:11
bpkroth added a commit that referenced this pull request Oct 24, 2025
# Pull Request

## Title

Split docker test fixtures

______________________________________________________________________

## Description

Splits docker test fixtures so that individual docker-compose projects
can be setup and torn down independently.

This improves single test performance (e.g., when SQL tests don't need
to setup SSH test fixtures) and parallelism by allowing each to operate
independently.

______________________________________________________________________

## Type of Change

- 🔄 Refactor
- 🧪 Tests

______________________________________________________________________

## Additional Notes (optional)

Should be merged after #994 

______________________________________________________________________

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci ready for review Ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

devcontainer missing azure-cli error devcontainer build error with pyrfr

3 participants