This repository was archived by the owner on Nov 16, 2023. It is now read-only.
Change Linear SVM lambda_ parameter to regularization - #255
Closed
gregorybchris wants to merge 3 commits into
Closed
Change Linear SVM lambda_ parameter to regularization#255gregorybchris wants to merge 3 commits into
gregorybchris wants to merge 3 commits into
Conversation
ganik
reviewed
Sep 6, 2019
| :param caching: Whether trainer should cache input training data. | ||
|
|
||
| :param lambda_: Regularizer constant. | ||
| :param regularization: Regularizer constant. |
Contributor
There was a problem hiding this comment.
These 3 files are auto generated from manifest.json. You could use manifest_diff.json to specify renaming of the parameter then re-run entrypoint_compiler tools with generate options set to True. There are many examples in manifest_diff.json how to do renaming. #Resolved
Contributor
|
duplicate of #259 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #254
The recently added Linear SVM learner uses the parameter name
lambda_to avoid Python reserved word conflicts withlambda. This PR changeslambda_tol2_regularization. This is more descriptive and avoids confusion where the trailing underscore could be mistaken as indicating a private variable.