Skip to content
This repository was archived by the owner on Nov 16, 2023. It is now read-only.

Update scikit-learn website links to use https instead of http - #56

Merged
justinormont merged 1 commit into
microsoft:masterfrom
GalOshri:update-scikit-learn-https
Nov 20, 2018
Merged

Update scikit-learn website links to use https instead of http#56
justinormont merged 1 commit into
microsoft:masterfrom
GalOshri:update-scikit-learn-https

Conversation

@GalOshri

Copy link
Copy Markdown
Contributor

Updating links to the scikit-learn website to use https instead of http.

This fixes #52.

Additionally, use the opportunity to update scikit-learn references in readme to lowercase to follow convention.

There are other http links that we might want to update in the future.

This was referenced Nov 20, 2018
@justinormont
justinormont merged commit bec566c into microsoft:master Nov 20, 2018
@montebhoover

Copy link
Copy Markdown
Contributor

@justinormont in response to your question on Teams, I'd like to figure out ways to improve the docs process so that it is less complicated.  In particular, all the .rst files in our source repo are copies of files in the official docs repo (copied and converted from .md to .rst), so the changes Gal made to those files won't have any effect.  It may be worthwhile to completely remove those files from the source repo since they are just copies - what do you think?  They originally existed before the creation of the docs repo, and now we maintain them because it is the typical python convention to keep docs files in the source repo in the structure that the Sphinx documentation generator expects.  

So we currently keep two copies of files so that we are compliant with both Microsoft Docs and Sphinx conventions, but we don't currently use Sphinx in any way. 

There is something nice about the Sphinx convention though - all docs and source are in the same repo (not possible with Microsoft Docs).  Up until a month ago, we followed the Sphinx conventions by default, as if there were no Microsoft Docs, and then had a designated person who would do a manual step to produce the copies and build for Microsoft Docs. But last month I proposed that we reverse this process in order to make it possible for people to edit the docs site simply by clicking the edit button on the webpage (we had some requests for this from Chris Lauren and the content developers). Now, we
edit the files in the Microsoft Docs repo and someone does a manual step to produce copies for the source repo.

Given all of that, should we let go of the Sphinx compliant copies to make things easier? Are there any other ways we can improve on this system?

@GalOshri
GalOshri deleted the update-scikit-learn-https branch November 21, 2018 21:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

https for sklearn

4 participants