Update to use ruff format - #1739
Closed
justinchuby wants to merge 9 commits into
Closed
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
lintrunner found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
justinchuby
commented
Apr 9, 2025
justinchuby
commented
Apr 9, 2025
justinchuby
commented
Apr 9, 2025
justinchuby
enabled auto-merge (squash)
April 9, 2025 23:18
jambayk
approved these changes
Apr 10, 2025
auto-merge was automatically disabled
April 10, 2025 00:19
Head branch was modified
justinchuby
enabled auto-merge (squash)
April 10, 2025 00:20
auto-merge was automatically disabled
April 10, 2025 00:25
Pull Request is not mergeable
Contributor
|
will close and open again to try to reset the merge check |
justinchuby
added a commit
that referenced
this pull request
Apr 10, 2025
Use ruff to replace black and isort for formatting because it is much faster and preserve much of the same styles. The same is done in ort/onnx/pytorch etc. Replaces #1739
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Use ruff to replace black and isort for formatting because it is much faster and preserve much of the same styles. The same is done in ort/onnx/pytorch etc.
Checklist before requesting a review
lintrunner -a(Optional) Issue link