Skip to content

Modify, cleanup, refactor, correct for OpenApiTag#45

Merged
xuzhg merged 1 commit into
microsoft:masterfrom
xuzhg:DomChanges
Oct 31, 2017
Merged

Modify, cleanup, refactor, correct for OpenApiTag#45
xuzhg merged 1 commit into
microsoft:masterfrom
xuzhg:DomChanges

Conversation

@xuzhg

@xuzhg xuzhg commented Oct 31, 2017

Copy link
Copy Markdown
Contributor
  1. Modify, cleanup, refactor, correct for OpenApitag
  2. Add Unit test for it

@xuzhg xuzhg changed the title Modify, cleanup, refactor, correct each element in DOM Modify, cleanup, refactor, correct for OpenApiTag Oct 31, 2017
writer.WriteStringProperty("description", Description);

// name
writer.WriteStringProperty(OpenApiConstants.OpenApiDocName, Name);

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove these comments

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed.

},
""x-tag-extension"": null
}";

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would put this in the Data too (so repeat this twice, once for 3.0 and once for 2.0). Even though 3.0 and 2.0 serialize to the same string, this is more of a circumstantial thing rather than something ingrained in the semantics.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to leave it unchanged until we move these into a file.

@PerthCharern PerthCharern left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@xuzhg xuzhg merged commit 83c5566 into microsoft:master Oct 31, 2017
@xuzhg xuzhg deleted the DomChanges branch October 31, 2017 20:44
baywet added a commit that referenced this pull request Nov 11, 2025
chore: disables WPF solution on non windows platforms
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants