Skip to content

Update build script and targeting nugets to allow the project to build on the windows-2022 image#78

Merged
cgallred merged 12 commits into
microsoft:mainfrom
yerudako:user/yerudako/fix-build-to-run-on-windows-2022
Dec 1, 2021
Merged

Update build script and targeting nugets to allow the project to build on the windows-2022 image#78
cgallred merged 12 commits into
microsoft:mainfrom
yerudako:user/yerudako/fix-build-to-run-on-windows-2022

Conversation

@yerudako
Copy link
Copy Markdown
Contributor

Fixes #77. This change is combined from @cgallred's and mine changes and based on this run Christian triggered with them, it might be enough changes to use Windows 2022 (Please ignore the test failures - these are related to the symlink branch and are not present in the baseline)

Changelog:

  • Props file updated to reference correct Windows SDK versions
  • Targeting nugets used to build 4.6.1 on windows-2022 env (which only has .NET Core and .NET 4.8 present)
  • Redundant components removed from the vswhere check
  • Version limits updated in the vswhere check

yerudako and others added 4 commits November 30, 2021 14:27
(cherry picked from commit ff7cd45)

# Conflicts:
#	scripts/BuildProjFS-Managed.bat
(cherry picked from commit 61db53a)
(cherry picked from commit 64de528)
@ghost
Copy link
Copy Markdown

ghost commented Nov 30, 2021

CLA assistant check
All CLA requirements met.

@narasamdya
Copy link
Copy Markdown
Contributor

Why do we need .NET 4.6.1 ? Is .NET 4.8 not sufficient?

@yerudako
Copy link
Copy Markdown
Contributor Author

yerudako commented Dec 1, 2021

Why do we need .NET 4.6.1 ? Is .NET 4.8 not sufficient?

@narasamdya the project builds in 4.6.1, so I assumed that it's supposed to be used by older client apps running 4.6.1 and added the targeting pack rather than retargeting it to 4.8. I would defer to @cgallred for whether it is critical to support 4.6.1 or whether we should migrate to 4.8.

@cgallred
Copy link
Copy Markdown
Collaborator

cgallred commented Dec 1, 2021

Why do we need .NET 4.6.1 ? Is .NET 4.8 not sufficient?

@narasamdya the project builds in 4.6.1, so I assumed that it's supposed to be used by older client apps running 4.6.1 and added the targeting pack rather than retargeting it to 4.8. I would defer to @cgallred for whether it is critical to support 4.6.1 or whether we should migrate to 4.8.

It targets 4.6.1 because for a long time there had been a requirement that it needed to run on RS1 (see this PR comment). That requirement no longer exists. From what I understand of the platforms .NET 4.8 is supported on (based on this doc), 4.8 is the current Framework version on all supported OS versions, right? Plus 4.6.1 will be retired on April 26th.

I think we can update to 4.8.

@yerudako
Copy link
Copy Markdown
Contributor Author

yerudako commented Dec 1, 2021

Sounds good @narasamdya @cgallred - I've updated the framework to 4.8 according to suggestions and removed the targeting packs. Seems as if both pipelines are happy with the changes.

Comment thread scripts/BuildProjFS-Managed.bat Outdated
@yerudako yerudako requested a review from cgallred December 1, 2021 02:55
@yerudako
Copy link
Copy Markdown
Contributor Author

yerudako commented Dec 1, 2021

@cgallred thanks for reviewing! Can I also ask you to merge it - it says I am not authorized to merge the Pull Request?

@cgallred cgallred merged commit b6fbd6b into microsoft:main Dec 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The build agent needs an upgrade to build against the new ProjFS API

4 participants