This repository was archived by the owner on Aug 21, 2024. It is now read-only.
Packages for restoring notebook perf#235
Merged
tcNickolas merged 8 commits intomasterfrom Nov 17, 2019
Merged
Conversation
added 2 commits
November 17, 2019 09:40
tcNickolas
approved these changes
Nov 17, 2019
Contributor
tcNickolas
left a comment
tcNickolas
left a comment
There was a problem hiding this comment.
Binder was running into some hiccups, but they look transient, it ended up building the image successfully, and faster than before the change (I'll have to do a more exact timing once it's merged).
Thank you for taking care of the perf issue!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Superseds #234 (sorry, having consistent naming for all branches across repos made it easier for me to keep track).
@tcNickolas This PR currently also removes the workspace file for VS Code. We had at some point agreed that removing it would be a good option given that if you use it all intellisense will be disabled. If this has changed then it's easy to add back.