Skip to content

fix: fix a bug in model tuning feedback #316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
WinstonLiyt merged 2 commits into from
Sep 24, 2024
Merged

fix: fix a bug in model tuning feedback #316

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cec000e
fix a bug
WinstonLiyt Sep 24, 2024
9748aa3
fix two bugs
WinstonLiyt Sep 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix two bugs
  • Loading branch information
@WinstonLiyt
WinstonLiyt committed Sep 24, 2024
commit 9748aa31957f67a94a0ec525fbb8aea00f3881c3
2 changes: 1 addition & 1 deletion rdagent/scenarios/kaggle/developer/feedback.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ def generate_feedback(self, exp: Experiment, hypothesis: Hypothesis, trace: Trac
# Prepare render dictionary
render_dict = {
"context": self.scen.get_scenario_all_desc(),
"last_hypothesis": trace.hist[-1][0].hypothesis if trace.hist else None,
"last_hypothesis": trace.hist[-1][0] if trace.hist else None,
"last_task_and_code": last_task_and_code,
"last_result": trace.hist[-1][1].result if trace.hist else None,
"hypothesis": hypothesis,
Expand Down
3 changes: 1 addition & 2 deletions rdagent/scenarios/kaggle/prompts.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,8 +149,7 @@ model_tuning_feedback_generation:
{% if last_hypothesis %}
Last Round Information:
Hypothesis: {{last_hypothesis.hypothesis}}
Task: {{last_task}}
Code Implemented: {{last_code}}
Last Task and Code: {{last_task_and_code}}
Result: {{last_result}}
{% else %}
This is the first round. No previous information available. As long as the performance is not too negative (eg.ICIR is greater than 0), treat it as successful. Do not set the threshold too high.
Expand Down