Skip to content

fix: target json type & round #662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
you-n-g merged 4 commits into from
Mar 5, 2025
Merged

fix: target json type & round #662

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5e5bf60
refactor: Rename direct_exp_gen to json_target_type in DSExpGen class
you-n-g Mar 5, 2025
13820ac
fix type
you-n-g Mar 5, 2025
07d294a
fix: Adjust loop iterations and update json_target_type for nested dicts
you-n-g Mar 5, 2025
887f92a
Merge branch 'main' into fix_target_json_type
you-n-g Mar 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion rdagent/oai/backend/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -378,7 +378,7 @@ def _create_chat_completion_auto_continue(

all_response = ""
new_messages = deepcopy(messages)
for _ in range(3):
for _ in range(6): # for some long code, 3 times may not enough for reasoning models
if "json_mode" in kwargs:
del kwargs["json_mode"]
response, finish_reason = self._create_chat_completion_add_json_in_prompt(
Expand Down
5 changes: 4 additions & 1 deletion rdagent/scenarios/data_science/proposal/exp_gen.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -420,7 +420,10 @@ def _f(user_prompt):
user_prompt=user_prompt,
system_prompt=system_prompt,
json_mode=True,
json_target_type=dict[str, dict[str, str] | str], # workflow_update may be a string
# NOTE: corner cases.
# workflow_update may be a string
# model could have 2 level nested dict.
json_target_type=dict[str, dict[str, str | dict] | str],
)
)
assert "hypothesis_proposal" in resp_dict, "Hypothesis proposal not provided."
Expand Down