Call SymSetParentWindow to ensure modal UI #131
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some cases, dbghelp / symsrv may pop up UI dialogs, such as to authenticate to a symbol server. We want those dialogs to be modal so that they are clearly visible to the user. Calling SymSetParentWindow ensures the modal nature of such possible UI elements.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| Contract.Requires(null != syms); | ||
| Contract.Requires(null != parent); | ||
|
|
||
| if (!SafeNativeMethods.SymSetParentWindow(System.Diagnostics.Process.GetCurrentProcess().MainWindowHandle)) return retval; |
Check notice
Code scanning / CodeQL
Calls to unmanaged code
|
|
||
| [DllImport("dbghelp.dll", CharSet = CharSet.Unicode)] public static extern bool SymInitialize(IntPtr hProcess, [MarshalAs(UnmanagedType.LPWStr)] string UserSearchPath, bool fInvadeProcess); | ||
|
|
||
| [DllImport("dbghelp.dll")] public static extern bool SymSetParentWindow(IntPtr hWnd); |
Check notice
Code scanning / CodeQL
Unmanaged code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases, dbghelp / symsrv may pop up UI dialogs, such as to authenticate to a symbol server. We want those dialogs to be modal so that they are clearly visible to the user. Calling SymSetParentWindow ensures the modal nature of such possible UI elements.