-
Notifications
You must be signed in to change notification settings - Fork 1.6k
improve flat_map specific coverage for GH-6045 #6247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mahtab04
wants to merge
1
commit into
microsoft:main
Choose a base branch
from
mahtab04:gh-6045/flat-map-comprehensive-tests
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+356
−0
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1417,6 +1417,356 @@ void test_non_strict_weak_order_compare() { | |
| } | ||
| } | ||
|
|
||
| void test_operator_subscript() { | ||
| { | ||
| flat_map<int, char> fm; | ||
|
|
||
| fm[10] = 'm'; | ||
| assert(fm[10] == 'm'); | ||
| assert(fm.size() == 1); | ||
|
|
||
| fm[70] = 'e'; | ||
| assert(fm[70] == 'e'); | ||
| assert(fm.size() == 2); | ||
|
|
||
| fm[10] = 'z'; | ||
| assert(fm[10] == 'z'); | ||
| assert(fm.size() == 2); | ||
|
|
||
| int key = 30; | ||
| fm[move(key)] = 'r'; | ||
| assert(fm[30] == 'r'); | ||
| assert(fm.size() == 3); | ||
|
|
||
| [[maybe_unused]] char& ref = fm[99]; | ||
| assert(fm[99] == '\0'); | ||
| assert(fm.size() == 4); | ||
|
|
||
| assert(check_key_content(fm, {10, 30, 70, 99})); | ||
| assert(check_value_content(fm, {'z', 'r', 'e', '\0'})); | ||
| } | ||
|
|
||
| { | ||
| flat_map<int, string> fm; | ||
| fm[1] = "hello"; | ||
| assert(fm[1] == "hello"); | ||
| assert(fm[2].empty()); | ||
| assert(fm.size() == 2); | ||
|
|
||
| assert(check_key_content(fm, {1, 2})); | ||
| assert(check_value_content(fm, {string{"hello"}, string{}})); | ||
| } | ||
|
|
||
| { | ||
| flat_map<Packaged<int>, char, TransparentPackagedCompare<int>> fm; | ||
| fm[5] = 'a'; | ||
| assert(fm.size() == 1); | ||
|
|
||
| fm[5] = 'b'; | ||
| assert(fm.size() == 1); | ||
| assert(fm.begin()->second == 'b'); | ||
|
|
||
| fm[10] = 'c'; | ||
| assert(fm.size() == 2); | ||
| assert(fm.find(10)->second == 'c'); | ||
|
|
||
| assert(check_key_content(fm, {Packaged<int>(5), Packaged<int>(10)})); | ||
| assert(check_value_content(fm, {'b', 'c'})); | ||
| } | ||
| } | ||
|
|
||
| void test_at() { | ||
| { | ||
| flat_map<int, char> fm{{10, 'm'}, {20, 'o'}, {70, 'e'}, {90, 'w'}}; | ||
|
|
||
| assert(fm.at(10) == 'm'); | ||
| assert(fm.at(20) == 'o'); | ||
| assert(fm.at(70) == 'e'); | ||
| assert(fm.at(90) == 'w'); | ||
|
|
||
| fm.at(10) = 'x'; | ||
| assert(fm.at(10) == 'x'); | ||
| assert(fm.size() == 4); | ||
| } | ||
|
|
||
| { | ||
| const flat_map<int, char> fm{{10, 'm'}, {20, 'o'}, {70, 'e'}, {90, 'w'}}; | ||
|
|
||
| assert(fm.at(10) == 'm'); | ||
| assert(fm.at(20) == 'o'); | ||
| assert(fm.at(70) == 'e'); | ||
| assert(fm.at(90) == 'w'); | ||
| } | ||
|
|
||
| { | ||
| flat_map<int, char> fm{{10, 'm'}, {20, 'o'}}; | ||
| bool caught = false; | ||
| try { | ||
| (void) fm.at(42); | ||
| } catch (const out_of_range&) { | ||
| caught = true; | ||
| } | ||
|
Comment on lines
+1504
to
+1508
|
||
| assert(caught); | ||
| } | ||
|
|
||
| { | ||
| const flat_map<int, char> fm{{10, 'm'}, {20, 'o'}}; | ||
| bool caught = false; | ||
| try { | ||
| (void) fm.at(42); | ||
| } catch (const out_of_range&) { | ||
| caught = true; | ||
| } | ||
| assert(caught); | ||
| } | ||
|
|
||
| { | ||
| flat_map<int, char> fm; | ||
| bool caught = false; | ||
| try { | ||
| (void) fm.at(0); | ||
| } catch (const out_of_range&) { | ||
| caught = true; | ||
| } | ||
| assert(caught); | ||
| } | ||
|
|
||
| { | ||
| flat_map<Packaged<int>, char, TransparentPackagedCompare<int>> fm; | ||
| fm.emplace(Packaged<int>(5), 'a'); | ||
| fm.emplace(Packaged<int>(10), 'b'); | ||
|
|
||
| assert(fm.at(5) == 'a'); | ||
| assert(fm.at(10) == 'b'); | ||
| fm.at(5) = 'z'; | ||
| assert(fm.at(5) == 'z'); | ||
|
|
||
| const auto& cfm = fm; | ||
| assert(cfm.at(5) == 'z'); | ||
| assert(cfm.at(10) == 'b'); | ||
|
|
||
| bool caught = false; | ||
| try { | ||
| (void) fm.at(99); | ||
| } catch (const out_of_range&) { | ||
| caught = true; | ||
| } | ||
| assert(caught); | ||
|
|
||
| bool caught_const = false; | ||
| try { | ||
| (void) cfm.at(99); | ||
| } catch (const out_of_range&) { | ||
| caught_const = true; | ||
| } | ||
| assert(caught_const); | ||
| } | ||
| } | ||
|
|
||
| void test_emplace() { | ||
| { | ||
| flat_map<int, char> fm; | ||
|
|
||
| const auto [it1, inserted1] = fm.emplace(10, 'm'); | ||
| assert(it1->first == 10); | ||
| assert(it1->second == 'm'); | ||
| assert(inserted1); | ||
|
|
||
| const auto [it2, inserted2] = fm.emplace(70, 'e'); | ||
| assert(it2->first == 70); | ||
| assert(it2->second == 'e'); | ||
| assert(inserted2); | ||
|
|
||
| const auto [it3, inserted3] = fm.emplace(20, 'o'); | ||
| assert(it3->first == 20); | ||
| assert(it3->second == 'o'); | ||
| assert(inserted3); | ||
|
|
||
| const auto [it4, inserted4] = fm.emplace(10, 'X'); | ||
| assert(it4->first == 10); | ||
| assert(it4->second == 'm'); | ||
| assert(!inserted4); | ||
|
|
||
| assert(check_key_content(fm, {10, 20, 70})); | ||
| assert(check_value_content(fm, {'m', 'o', 'e'})); | ||
| } | ||
|
|
||
| { | ||
| flat_map<int, char> fm; | ||
|
|
||
| const auto [it1, inserted1] = fm.emplace(pair{5, 'a'}); | ||
| assert(it1->first == 5); | ||
| assert(it1->second == 'a'); | ||
| assert(inserted1); | ||
|
|
||
| const auto [it2, inserted2] = fm.emplace(pair{5, 'b'}); | ||
| assert(it2->first == 5); | ||
| assert(it2->second == 'a'); | ||
| assert(!inserted2); | ||
| } | ||
|
|
||
| { | ||
| flat_map<int, char> fm{{1, 'a'}, {5, 'e'}, {10, 'j'}}; | ||
|
|
||
| const auto it1 = fm.emplace_hint(fm.end(), 20, 't'); | ||
| assert(it1->first == 20); | ||
| assert(it1->second == 't'); | ||
|
|
||
| const auto it2 = fm.emplace_hint(fm.begin(), 0, 'z'); | ||
| assert(it2->first == 0); | ||
| assert(it2->second == 'z'); | ||
|
|
||
| const auto it3 = fm.emplace_hint(fm.find(5), 5, 'X'); | ||
| assert(it3->first == 5); | ||
| assert(it3->second == 'e'); | ||
|
|
||
| assert(check_key_content(fm, {0, 1, 5, 10, 20})); | ||
| assert(check_value_content(fm, {'z', 'a', 'e', 'j', 't'})); | ||
| } | ||
| } | ||
|
|
||
| void test_try_emplace() { | ||
| { | ||
| flat_map<int, string> fm; | ||
|
|
||
| const auto [it1, ins1] = fm.try_emplace(10, "hello"); | ||
| assert(it1->first == 10); | ||
| assert(it1->second == "hello"); | ||
| assert(ins1); | ||
|
|
||
| const auto [it2, ins2] = fm.try_emplace(20, size_t{3}, 'x'); | ||
| assert(it2->first == 20); | ||
| assert(it2->second == "xxx"); | ||
| assert(ins2); | ||
|
|
||
| const auto [it3, ins3] = fm.try_emplace(10, "world"); | ||
| assert(it3->first == 10); | ||
| assert(it3->second == "hello"); | ||
| assert(!ins3); | ||
|
|
||
| assert(fm.size() == 2); | ||
| } | ||
|
|
||
| { | ||
| flat_map<int, char> fm; | ||
|
|
||
| int key1 = 10; | ||
| const auto [it1, ins1] = fm.try_emplace(move(key1), 'm'); | ||
| assert(it1->first == 10); | ||
| assert(it1->second == 'm'); | ||
| assert(ins1); | ||
|
|
||
| int key2 = 10; | ||
| const auto [it2, ins2] = fm.try_emplace(move(key2), 'X'); | ||
| assert(it2->first == 10); | ||
| assert(it2->second == 'm'); | ||
| assert(!ins2); | ||
| } | ||
|
|
||
| { | ||
| flat_map<int, char> fm{{1, 'a'}, {5, 'e'}, {10, 'j'}}; | ||
|
|
||
| const auto it1 = fm.try_emplace(fm.end(), 20, 't'); | ||
| assert(it1->first == 20); | ||
| assert(it1->second == 't'); | ||
|
|
||
| const auto it2 = fm.try_emplace(fm.begin(), 0, 'z'); | ||
| assert(it2->first == 0); | ||
| assert(it2->second == 'z'); | ||
|
|
||
| const auto it3 = fm.try_emplace(fm.find(5), 5, 'X'); | ||
| assert(it3->first == 5); | ||
| assert(it3->second == 'e'); | ||
|
|
||
| assert(check_key_content(fm, {0, 1, 5, 10, 20})); | ||
| assert(check_value_content(fm, {'z', 'a', 'e', 'j', 't'})); | ||
| } | ||
|
|
||
| { | ||
| flat_map<int, char> fm{{1, 'a'}, {5, 'e'}, {10, 'j'}}; | ||
|
|
||
| const auto it1 = fm.try_emplace(fm.begin(), 20, 't'); | ||
| assert(it1->first == 20); | ||
| assert(it1->second == 't'); | ||
|
|
||
| assert(check_key_content(fm, {1, 5, 10, 20})); | ||
| assert(check_value_content(fm, {'a', 'e', 'j', 't'})); | ||
| } | ||
|
|
||
| { | ||
| flat_map<Packaged<int>, char, TransparentPackagedCompare<int>> fm; | ||
|
|
||
| const auto [it1, ins1] = fm.try_emplace(5, 'a'); | ||
| assert(ins1); | ||
| assert(it1->first == Packaged<int>(5)); | ||
| assert(it1->second == 'a'); | ||
|
|
||
| const auto [it2, ins2] = fm.try_emplace(10, 'b'); | ||
| assert(ins2); | ||
|
|
||
| const auto [it3, ins3] = fm.try_emplace(5, 'X'); | ||
| assert(!ins3); | ||
| assert(it3->second == 'a'); | ||
|
|
||
| assert(fm.size() == 2); | ||
| } | ||
|
|
||
| { | ||
| flat_map<Packaged<int>, char, TransparentPackagedCompare<int>> fm; | ||
| fm.try_emplace(5, 'a'); | ||
| fm.try_emplace(10, 'b'); | ||
|
|
||
| const auto it = fm.try_emplace(fm.end(), 20, 'c'); | ||
| assert(it->first == Packaged<int>(20)); | ||
| assert(it->second == 'c'); | ||
| assert(fm.size() == 3); | ||
| } | ||
| } | ||
|
|
||
| void test_replace() { | ||
| { | ||
| flat_map<int, char> fm{{1, 'a'}, {2, 'b'}, {3, 'c'}}; | ||
|
|
||
| vector<int> new_keys = {10, 20, 30, 40}; | ||
| vector<char> new_vals = {'w', 'x', 'y', 'z'}; | ||
| fm.replace(move(new_keys), move(new_vals)); | ||
|
|
||
| assert(check_key_content(fm, {10, 20, 30, 40})); | ||
| assert(check_value_content(fm, {'w', 'x', 'y', 'z'})); | ||
| } | ||
|
|
||
| { | ||
| flat_map<int, char> fm{{1, 'a'}, {2, 'b'}}; | ||
|
|
||
| fm.replace(vector<int>{}, vector<char>{}); | ||
|
|
||
| assert(fm.empty()); | ||
| } | ||
|
|
||
| { | ||
| flat_map<int, char> fm; | ||
|
|
||
| vector<int> new_keys = {42}; | ||
| vector<char> new_vals = {'x'}; | ||
| fm.replace(move(new_keys), move(new_vals)); | ||
|
|
||
| assert(fm.size() == 1); | ||
| assert(fm.begin()->first == 42); | ||
| assert(fm.begin()->second == 'x'); | ||
| } | ||
|
|
||
| { | ||
| flat_map<int, char> fm{{1, 'a'}, {2, 'b'}, {3, 'c'}}; | ||
|
|
||
| auto extracted = move(fm).extract(); | ||
| assert(fm.empty()); | ||
|
|
||
| fm.replace(move(extracted.keys), move(extracted.values)); | ||
| assert(check_key_content(fm, {1, 2, 3})); | ||
| assert(check_value_content(fm, {'a', 'b', 'c'})); | ||
| } | ||
| } | ||
|
|
||
| void run_normal_tests() { | ||
| test_key_mapped_cont_combinations<vector, vector>(); | ||
| test_key_mapped_cont_combinations<vector, deque>(); | ||
|
|
@@ -1434,6 +1784,12 @@ void run_normal_tests() { | |
|
|
||
| test_lookup_call_on_temporaries(); | ||
| test_non_strict_weak_order_compare(); | ||
|
|
||
| test_operator_subscript(); | ||
| test_at(); | ||
| test_emplace(); | ||
| test_try_emplace(); | ||
| test_replace(); | ||
| } | ||
|
|
||
| enum class cont_type { multi, unique }; | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test uses
std::stringbut the file doesn't include<string>directly. Relying on transitive includes (e.g., via other standard headers) is brittle and can break when headers change; add an explicit#include <string>in the include list for this test file.