Expose webgl types to worker#561
Merged
Merged
Conversation
Contributor
|
//cc @RyanCavanaugh |
Member
|
@saschanaz what's going on with the Travis failures? |
Collaborator
Author
|
Ah, currently waiting KhronosGroup/WebGL#2504. Sorry for the confusion! |
saschanaz
force-pushed
the
webgl-update
branch
from
e49fac9 to
9050386
Compare
Collaborator
Author
|
Hi @RyanCavanaugh, I fixed the errors, assuming we have all extensions in worker environment. Can you review again? |
sandersn
approved these changes
Oct 29, 2018
Member
sandersn
left a comment
sandersn
left a comment
There was a problem hiding this comment.
Looks good, but can you merge from master?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
... as the spec is updated so.