feat: Use declare class where possible#858
Closed
ExE-Boss wants to merge 2 commits intomicrosoft:masterfrom
Closed
feat: Use declare class where possible#858ExE-Boss wants to merge 2 commits intomicrosoft:masterfrom
declare class where possible#858ExE-Boss wants to merge 2 commits intomicrosoft:masterfrom
Conversation
ea1e436 to
e55795c
Compare
saschanaz
reviewed
Jun 5, 2020
| } | ||
|
|
||
| const newToConstructorRegExp = /^new(?:<.+?>)?(\(.+?\))(?:: ?[^)]+)?$/u; | ||
| function convertNewToConstructor(signature: string) { |
Collaborator
There was a problem hiding this comment.
This seems only for manual JSON data, in that case I think those should be fixed instead.
Member
|
This is a possibly gigantic breaking change. I created a PR on Typescript, microsoft/TypeScript#39044, so we can run DT and other tests on it. |
Member
|
We discussed this in the design meeting and decided not to take this change.
|
Collaborator
|
Added a comment: microsoft/TypeScript#39054 (comment) |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes emit for interfaces:
From:
To:
Which has the added benefit of supporting declaration merging for static methods and properties.
It also prevents static properties from breaking
// $ExpectTypeon constructors, since it just becomes// $ExpecType typeof Foo.This shouldn’t be a breaking change as existing consumers will keep working just fine, this just opens up new ways to extends these definitions.