property transformation visitor doesn't take into account exclamationToken

[cevek]

TypeScript Version: 3.0.0-dev.20180712

Search Terms:

Code

visitor.ts

 case SyntaxKind.PropertyDeclaration:
                return updateProperty(<PropertyDeclaration>node,
                    nodesVisitor((<PropertyDeclaration>node).decorators, visitor, isDecorator),
                    nodesVisitor((<PropertyDeclaration>node).modifiers, visitor, isModifier),
                    visitNode((<PropertyDeclaration>node).name, visitor, isPropertyName),
           // here must be questionToken or exclamationToken
                    visitNode((<PropertyDeclaration>node).questionToken, tokenVisitor, isToken), 
                    visitNode((<PropertyDeclaration>node).type, visitor, isTypeNode),
                    visitNode((<PropertyDeclaration>node).initializer, visitor, isExpression));


function updateProperty(node: PropertyDeclaration, decorators: ReadonlyArray<Decorator> | undefined, modifiers: ReadonlyArray<Modifier> | undefined, name: string | PropertyName, questionOrExclamationToken: QuestionToken | ExclamationToken | undefined, type: TypeNode | undefined, initializer: Expression | undefined): PropertyDeclaration;
    

Expected behavior:

Actual behavior:

Playground Link:

Related Issues:

[cevek]

And because of that some branches of the ast which contains class members with ! always be rebuilt

[mhegazy]

PRs welcomed.