Skip to content

Make ScriptElementKind and HighlightSpanKind string enums #15966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
6 commits merged into from
May 23, 2017
Merged

Make ScriptElementKind and HighlightSpanKind string enums #15966

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b162097
Make ScriptElementKind and HighlightSpanKind string enums
May 20, 2017
f94818d
Also convert ClassificationTypeNames and CommandTypes/CommandNames
May 22, 2017
3b56ebe
Convert other namespace + type alias in protocol.ts to const enums
May 22, 2017
c6e69dd
Fix missing initializers
May 22, 2017
f6240cb
Make CommandTypes a const enum and use `allCommandTypes` for unit test
May 22, 2017
b1e100e
Merge branch 'master' into kind
May 23, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix missing initializers
  • Loading branch information
Andy Hanson committed May 22, 2017
commit c6e69dd64ba26a29900e7f296d2df3cc8d22767d
4 changes: 2 additions & 2 deletions src/server/protocol.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2416,8 +2416,8 @@ namespace ts.server.protocol {
}

export const enum NewLineKind {
Copy link
Contributor

@mhegazy mhegazy May 22, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing the initialization here.

Crlf,
Lf,
Crlf = "Crlf",
Lf = "Lf",
}

export const enum ScriptTarget {
Expand Down