Conversation
Contributor
|
👍 |
Contributor
There was a problem hiding this comment.
maybe , generateName: NameGenerator along with type NameGenerator = (node: Node) => string; ?
I find it pretty tough to read these sigs with function types in it. But it's up to you.
Contributor
|
👍 |
Contributor
There was a problem hiding this comment.
so we are chaining these to a boolean flag.
Contributor
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR uses
isUnknownIdentifierfrom the checker to determine if let\const should be renamed. When new name is generated it will be unique within the set { globals U identifiers-in-file U generated-names }. Names for temp variables and globally uniqie names are generated using different patterns and so should never conflict.Fixes #2449