Skip to content

Add globalThis #29332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sandersn merged 27 commits into from
Feb 27, 2019
Merged

Add globalThis #29332

Changes from 1 commit
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
a5484dd
Restore original code from bind-toplevel-this
sandersn Jan 7, 2019
f650492
Working in JS, but the symbol is not right.
sandersn Jan 8, 2019
4bab559
Check in TS also; update some tests
sandersn Jan 8, 2019
d62a8d8
Update baselines
sandersn Jan 8, 2019
f07c5d6
Handle type references to globalThis
sandersn Jan 9, 2019
80558a4
Restore former behaviour of implicitThis errors
sandersn Jan 9, 2019
e3fbe5c
Test values with type globalThis
sandersn Jan 9, 2019
88c6f7d
Add esnext declaration for globalThis
sandersn Jan 9, 2019
f1ebbad
Merge branch 'master' into add-globalThis
sandersn Jan 9, 2019
4215a76
Switch to symbol-based approach
sandersn Jan 9, 2019
620177f
Merge branch 'master' into add-globalThis
sandersn Jan 9, 2019
d48cc4c
Do not suggest globals for completions at toplevel
sandersn Jan 9, 2019
719cc35
Add tests of element and property access
sandersn Jan 9, 2019
6b18334
Look up globalThis using normal resolution
sandersn Jan 16, 2019
7a3d714
Update fourslash tests
sandersn Jan 16, 2019
fc10811
Merge branch 'master' into add-globalThis
sandersn Jan 16, 2019
9fe7d87
Add missed fourslash test update
sandersn Jan 16, 2019
9db574a
Remove esnext.globalthis.d.ts too
sandersn Jan 17, 2019
3b27dc4
Add chained globalThis self-lookup test
sandersn Jan 18, 2019
1bd4a0d
Merge branch 'master' into add-globalThis
sandersn Jan 18, 2019
e5216f6
Merge branch 'master' into add-globalThis
sandersn Jan 25, 2019
d4d5be4
Attempt at making globalThis readonly
sandersn Jan 29, 2019
3ac9fac
Merge branch 'master' into add-globalThis
sandersn Feb 19, 2019
00312cd
Add/update tests
sandersn Feb 19, 2019
25ad4d1
Merge branch 'master' into add-globalThis
sandersn Feb 21, 2019
6b674f2
Merge branch 'master' into add-globalThis
sandersn Feb 27, 2019
517dc15
Addres PR comments:
sandersn Feb 27, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add missed fourslash test update
  • Loading branch information
@sandersn
sandersn committed Jan 16, 2019
commit 9fe7d87420664f3a4bc75d37b87b22c40d954e7b
4 changes: 2 additions & 2 deletions tests/cases/fourslash/completionsImport_exportEquals_anonymous.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ goTo.marker("0");
const preferences: FourSlashInterface.UserPreferences = { includeCompletionsForModuleExports: true };
const exportEntry: FourSlashInterface.ExpectedCompletionEntryObject = { name: "fooBar", source: "/src/foo-bar", sourceDisplay: "./foo-bar", text: "(property) export=: 0", kind: "property", hasAction: true };
verify.completions(
{ marker: "0", exact: ["undefined", exportEntry, ...completion.statementKeywordsWithTypes], preferences },
{ marker: "0", exact: ["undefined", "globalThis", exportEntry, ...completion.statementKeywordsWithTypes], preferences },
{ marker: "1", includes: exportEntry, preferences }
);
verify.applyCodeActionFromCompletion("0", {
Expand All @@ -25,4 +25,4 @@ verify.applyCodeActionFromCompletion("0", {

exp
fooB`,
});
});