Skip to content

Improve soundness of indexed access types #30769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ahejlsberg merged 22 commits into from
Apr 12, 2019
+1,602 −264
Merged

Improve soundness of indexed access types #30769

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
fc95dc4
Improve soundness of indexed access type relations
ahejlsberg Mar 29, 2019
5de3ee8
getIndexedAccessType for assignment target uses intersections
ahejlsberg Mar 30, 2019
95c8a92
Add getIndexedAccessOrUndefined function
ahejlsberg Mar 31, 2019
3e09d29
Accept new baselines
ahejlsberg Mar 31, 2019
d61a693
More exploration of indexed access type constraints in type relations
ahejlsberg Apr 2, 2019
1648d0c
Minor fixes
ahejlsberg Apr 2, 2019
e79e0bd
Accept new baselines
ahejlsberg Apr 2, 2019
d69aeb4
T[K] ignores index signatures in T's constraint
ahejlsberg Apr 4, 2019
f5f1f30
Accept new baselines
ahejlsberg Apr 4, 2019
739acee
Add tests
ahejlsberg Apr 4, 2019
e01fa85
Accept new baselines
ahejlsberg Apr 4, 2019
2945802
Merge branch 'master' into saferIndexedAccessTypes
ahejlsberg Apr 6, 2019
9832a83
Accept new baselines
ahejlsberg Apr 6, 2019
e1fd5e5
Fix unsafe parameter coercions related to PragmaPseudoMap
ahejlsberg Apr 6, 2019
b49a343
Simplify obtaining base constraint of T[K] for writing
ahejlsberg Apr 8, 2019
71f3e1f
Accept new baselines
ahejlsberg Apr 8, 2019
eb1e7ec
Optimize T[K] where T has string index signature and no other members
ahejlsberg Apr 8, 2019
6851268
Accept new baselines
ahejlsberg Apr 8, 2019
fa407ce
Remove old comment
ahejlsberg Apr 9, 2019
c8ff4bd
Properly filter mapped types in getIndexType with noIndexSignatures=true
ahejlsberg Apr 10, 2019
68eb7b9
Add test
ahejlsberg Apr 10, 2019
6785472
Accept new baselines
ahejlsberg Apr 10, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Accept new baselines
  • Loading branch information
@ahejlsberg
ahejlsberg committed Apr 10, 2019
commit 67854725a8d520530885d48dc2983163cc0d7da5
28 changes: 18 additions & 10 deletions tests/baselines/reference/keyofAndIndexedAccess2.errors.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,21 +12,22 @@ tests/cases/conformance/types/keyof/keyofAndIndexedAccess2.ts(19,5): error TS232
tests/cases/conformance/types/keyof/keyofAndIndexedAccess2.ts(26,7): error TS2339: Property 'x' does not exist on type 'T'.
tests/cases/conformance/types/keyof/keyofAndIndexedAccess2.ts(27,5): error TS2322: Type '1' is not assignable to type 'T[keyof T]'.
tests/cases/conformance/types/keyof/keyofAndIndexedAccess2.ts(31,5): error TS2322: Type '{ [key: string]: number; }' is not assignable to type '{ [P in K]: number; }'.
tests/cases/conformance/types/keyof/keyofAndIndexedAccess2.ts(45,3): error TS7017: Element implicitly has an 'any' type because type 'Item' has no index signature.
tests/cases/conformance/types/keyof/keyofAndIndexedAccess2.ts(46,3): error TS2322: Type '123' is not assignable to type 'string & number'.
tests/cases/conformance/types/keyof/keyofAndIndexedAccess2.ts(38,5): error TS2322: Type '{ [x: string]: number; }' is not assignable to type '{ [P in K]: number; }'.
tests/cases/conformance/types/keyof/keyofAndIndexedAccess2.ts(50,3): error TS7017: Element implicitly has an 'any' type because type 'Item' has no index signature.
tests/cases/conformance/types/keyof/keyofAndIndexedAccess2.ts(51,3): error TS2322: Type '123' is not assignable to type 'string & number'.
Type '123' is not assignable to type 'string'.
tests/cases/conformance/types/keyof/keyofAndIndexedAccess2.ts(47,3): error TS2322: Type '123' is not assignable to type 'T[keyof T]'.
tests/cases/conformance/types/keyof/keyofAndIndexedAccess2.ts(48,3): error TS2322: Type '123' is not assignable to type 'T[K]'.
tests/cases/conformance/types/keyof/keyofAndIndexedAccess2.ts(60,7): error TS2339: Property 'foo' does not exist on type 'T'.
tests/cases/conformance/types/keyof/keyofAndIndexedAccess2.ts(61,3): error TS2536: Type 'string' cannot be used to index type 'T'.
tests/cases/conformance/types/keyof/keyofAndIndexedAccess2.ts(62,3): error TS2322: Type '123' is not assignable to type 'T[keyof T]'.
tests/cases/conformance/types/keyof/keyofAndIndexedAccess2.ts(63,3): error TS2322: Type '123' is not assignable to type 'T[K]'.
tests/cases/conformance/types/keyof/keyofAndIndexedAccess2.ts(103,5): error TS2322: Type '123' is not assignable to type 'Type[K]'.
tests/cases/conformance/types/keyof/keyofAndIndexedAccess2.ts(52,3): error TS2322: Type '123' is not assignable to type 'T[keyof T]'.
tests/cases/conformance/types/keyof/keyofAndIndexedAccess2.ts(53,3): error TS2322: Type '123' is not assignable to type 'T[K]'.
tests/cases/conformance/types/keyof/keyofAndIndexedAccess2.ts(65,7): error TS2339: Property 'foo' does not exist on type 'T'.
tests/cases/conformance/types/keyof/keyofAndIndexedAccess2.ts(66,3): error TS2536: Type 'string' cannot be used to index type 'T'.
tests/cases/conformance/types/keyof/keyofAndIndexedAccess2.ts(67,3): error TS2322: Type '123' is not assignable to type 'T[keyof T]'.
tests/cases/conformance/types/keyof/keyofAndIndexedAccess2.ts(68,3): error TS2322: Type '123' is not assignable to type 'T[K]'.
tests/cases/conformance/types/keyof/keyofAndIndexedAccess2.ts(108,5): error TS2322: Type '123' is not assignable to type 'Type[K]'.
Type '123' is not assignable to type '123 & "some string"'.
Type '123' is not assignable to type '"some string"'.


==== tests/cases/conformance/types/keyof/keyofAndIndexedAccess2.ts (22 errors) ====
==== tests/cases/conformance/types/keyof/keyofAndIndexedAccess2.ts (23 errors) ====
function f1(obj: { a: number, b: 0 | 1, c: string }, k0: 'a', k1: 'a' | 'b', k2: 'a' | 'b' | 'c') {
obj[k0] = 1;
obj[k0] = 2;
Expand Down Expand Up @@ -90,6 +91,13 @@ tests/cases/conformance/types/keyof/keyofAndIndexedAccess2.ts(103,5): error TS23
a[k] = 1;
}

function f3b<K extends string>(a: { [P in K]: number }, b: { [P in string]: number }, k: K) {
a = b; // Error, index signature doesn't imply properties are present
~
!!! error TS2322: Type '{ [x: string]: number; }' is not assignable to type '{ [P in K]: number; }'.
b = a;
}

function f4<K extends string>(a: { [key: string]: number }[K], b: number) {
a = b;
b = a;
Expand Down
9 changes: 9 additions & 0 deletions tests/baselines/reference/keyofAndIndexedAccess2.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,11 @@ function f3<K extends string>(a: { [P in K]: number }, b: { [key: string]: numbe
a[k] = 1;
}

function f3b<K extends string>(a: { [P in K]: number }, b: { [P in string]: number }, k: K) {
a = b; // Error, index signature doesn't imply properties are present
b = a;
}

function f4<K extends string>(a: { [key: string]: number }[K], b: number) {
a = b;
b = a;
Expand Down Expand Up @@ -139,6 +144,10 @@ function f3(a, b, k) {
a[k];
a[k] = 1;
}
function f3b(a, b, k) {
a = b; // Error, index signature doesn't imply properties are present
b = a;
}
function f4(a, b) {
a = b;
b = a;
Expand Down
Loading