Remove technically unnecessary 'module' option from 'harness' config.#40526
Merged
DanielRosenwasser merged 1 commit intomasterfrom Sep 13, 2020
Merged
Remove technically unnecessary 'module' option from 'harness' config.#40526DanielRosenwasser merged 1 commit intomasterfrom
DanielRosenwasser merged 1 commit intomasterfrom
Conversation
DanielRosenwasser
requested review from
RyanCavanaugh,
orta,
sheetalkamat and
weswigham
typescript-bot
added
the
For Uncommitted Bug
Member
Author
|
Good job bot, ultimately you know I'm going to merge this in 30 minutes to see if it fixes the nightly publish. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #40525
https://github.com/microsoft/TypeScript/runs/1105196341?check_suite_focus=true#step:4:132