Skip to content

Fix compiler crash on property symbols without declarations #45190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gabritto merged 11 commits into from
Jul 29, 2021
Merged

Fix compiler crash on property symbols without declarations #45190

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
0a4e18e
don't track computed name if symbol has no declaration
gabritto Jul 21, 2021
a70b61a
add compiler test
gabritto Jul 22, 2021
d99fa05
add non serializable property declaration emit error
gabritto Jul 22, 2021
131b371
don't track computed name if symbol has no declaration
gabritto Jul 21, 2021
b2ce868
add compiler test
gabritto Jul 22, 2021
2609519
add non serializable property declaration emit error
gabritto Jul 22, 2021
0dfc68a
fix small stuff
gabritto Jul 26, 2021
9b5be77
Merge branch 'gabritto/issue44970' of https://github.com/microsoft/Ty…
gabritto Jul 26, 2021
624aca6
rebase: add non serializable property declaration emit error
gabritto Jul 22, 2021
7dbd39e
Merge branch 'gabritto/issue44970' of https://github.com/microsoft/Ty…
gabritto Jul 26, 2021
4196217
use symbolToString instead of symbolName
gabritto Jul 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
don't track computed name if symbol has no declaration
  • Loading branch information
@gabritto
gabritto committed Jul 21, 2021
commit 0a4e18e61c8745c0a059d805413552ff4bdfce88
20 changes: 11 additions & 9 deletions src/compiler/checker.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5243,16 +5243,18 @@ namespace ts {
const saveEnclosingDeclaration = context.enclosingDeclaration;
context.enclosingDeclaration = undefined;
if (context.tracker.trackSymbol && getCheckFlags(propertySymbol) & CheckFlags.Late && isLateBoundName(propertySymbol.escapedName)) {
const decl = first(propertySymbol.declarations!);
if (propertySymbol.declarations && hasLateBindableName(decl)) {
if (isBinaryExpression(decl)) {
const name = getNameOfDeclaration(decl);
if (name && isElementAccessExpression(name) && isPropertyAccessEntityNameExpression(name.argumentExpression)) {
trackComputedName(name.argumentExpression, saveEnclosingDeclaration, context);
if (propertySymbol.declarations) {
const decl = first(propertySymbol.declarations);
if (hasLateBindableName(decl)) {
if (isBinaryExpression(decl)) {
const name = getNameOfDeclaration(decl);
if (name && isElementAccessExpression(name) && isPropertyAccessEntityNameExpression(name.argumentExpression)) {
trackComputedName(name.argumentExpression, saveEnclosingDeclaration, context);
}
}
else {
trackComputedName(decl.name.expression, saveEnclosingDeclaration, context);
}
}
else {
trackComputedName(decl.name.expression, saveEnclosingDeclaration, context);
}
}
}
Expand Down