Skip to content
Merged
Changes from 1 commit
Commits
Show all changes
43 commits
Select commit Hold shift + click to select a range
0c24ccc
Infer type predicates from function bodies
danvk Feb 20, 2024
e2684f1
Run formatter
danvk Feb 21, 2024
101df93
Add secondary subtype check and tests
danvk Feb 21, 2024
d0e385e
add union type test to baselines
danvk Feb 21, 2024
a72b1f1
add prisma circularity test with failing baseline
danvk Feb 23, 2024
ef2d465
Various fixes for circularity issue
danvk Feb 23, 2024
9336052
circularity test is fixed
danvk Feb 23, 2024
41f624d
revert back to CheckMode.TypeOnly
danvk Feb 23, 2024
52df115
Add test case for a predicate that throws
danvk Feb 23, 2024
3ab6fae
Drop isTriviallyNonBoolean, switch to simpler test, check for assertions
danvk Feb 26, 2024
9591231
Use unescapeLeadingUnderscores
danvk Feb 29, 2024
9a8c0a1
tests are fixed
danvk Feb 29, 2024
a4ff6b4
Always bind flow nodes to return statements + other fixes
ahejlsberg Mar 1, 2024
869422f
Accept new baselines
ahejlsberg Mar 1, 2024
adbdc7d
Merge branch 'suggested-changes-57465' into infer-type-predicate-16069
danvk Mar 1, 2024
0dec9c6
simplify
danvk Mar 1, 2024
703253a
Delay expensive functionHasImplicitReturn call
ahejlsberg Mar 2, 2024
c7f1c3d
Avoid creating closures
ahejlsberg Mar 2, 2024
25743a3
Add fallback isTypeAssignableTo check to test for equivalence
danvk Mar 2, 2024
4e79d76
try caching the antecedent
danvk Mar 3, 2024
a5725d2
revert fallback assignability check
danvk Mar 3, 2024
3323573
Revert "try caching the antecedent"
danvk Mar 4, 2024
76a5abd
Merge commit 'c7f1c3d309' into infer-type-predicate-16069
danvk Mar 4, 2024
5ec6f1f
accept baselines
danvk Mar 13, 2024
3491c78
ignore rest parameters & update baseline
danvk Mar 13, 2024
c4ee1f0
switch to getParameterCount
danvk Mar 13, 2024
4e934fa
Revert "switch to getParameterCount"
danvk Mar 14, 2024
37951ca
Revert "ignore rest parameters & update baseline"
danvk Mar 14, 2024
cabed97
Revert "accept baselines"
danvk Mar 14, 2024
6a88111
try setting @declaration: true
danvk Mar 14, 2024
151d026
accept baselines
danvk Mar 14, 2024
0b6a24a
Merge branch 'main' into test-fix-expt-16069
danvk Mar 14, 2024
0f31362
accept baseline
danvk Mar 14, 2024
2354072
Add rest parameter test and accept baselines
danvk Mar 13, 2024
f63105c
ignore rest parameters & update baseline
danvk Mar 13, 2024
eea3994
switch to getParameterCount
danvk Mar 13, 2024
e474bfc
accept baseline
danvk Mar 14, 2024
a6a734c
emit inferred type predicates in createReturnTypeOfSignatureDeclaration
danvk Mar 14, 2024
f5a9404
accept baselines
danvk Mar 14, 2024
784e2a3
correct isDate / flakyIsDate pair
danvk Mar 14, 2024
33826df
handle asserts predicates as well
danvk Mar 14, 2024
f002b28
Pass flags for type predicate emit
danvk Mar 14, 2024
50803a0
Factor out nodeBuilder.typePredicateToTypePredicateNode
danvk Mar 15, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
accept baselines
  • Loading branch information
danvk committed Mar 14, 2024
commit 151d026596e05d880cdbc63019717d7b7dc24168
78 changes: 78 additions & 0 deletions tests/baselines/reference/inferTypePredicates.js
Original file line number Diff line number Diff line change
Expand Up @@ -496,3 +496,81 @@ function isNumberWithThis(x) {
function narrowFromAny(x) {
return typeof x === 'number';
}


//// [inferTypePredicates.d.ts]
declare const numsOrNull: (number | null)[];
declare const filteredNumsTruthy: number[];
declare const filteredNumsNonNullish: number[];
declare const evenSquaresInline: number[];
declare const isTruthy: (x: number | null) => boolean;
declare const evenSquares: number[];
declare const evenSquaresNonNull: number[];
declare function isNonNull(x: number | null): boolean;
declare function isNonNullVar(x: number | null): boolean;
declare function isNonNullGeneric<T>(x: T): boolean;
declare const myGuard: (o: string | undefined) => o is string;
declare const mySecondGuard: (o: string | undefined) => o is string;
type MyObj = {
data?: string;
};
type MyArray = {
list?: MyObj[];
}[];
declare const myArray: MyArray;
declare const result: any[][];
declare const result2: any[][];
type Foo = {
foo: string;
};
type Bar = Foo & {
bar: string;
};
declare const list: (Foo | Bar)[];
declare const resultBars: Bar[];
declare function isBarNonNull(x: Foo | Bar | null): boolean;
declare const fooOrBar: Foo | Bar;
declare const a: string[];
declare function backwardsGuard(x: number | string): x is number;
declare function isString(x: string | number): boolean;
declare let strOrNum: string | number;
declare function flakyIsString(x: string | number): boolean;
declare function isDate(x: object): x is Date;
declare function flakyIsDate(x: object): x is Date;
declare let maybeDate: object;
declare function irrelevantIsNumber(x: string | number): boolean;
declare function irrelevantIsNumberDestructuring(x: string | number): boolean;
declare function areBothNums(x: string | number, y: string | number): boolean;
declare function doubleReturn(x: string | number): boolean;
declare function guardsOneButNotOthers(a: string | number, b: string | number, c: string | number): boolean;
declare function dunderguard(__x: number | string): boolean;
declare const booleanIdentity: (x: boolean) => boolean;
declare const numOrBoolean: (x: number | boolean) => x is number | true;
interface NumberInferrer {
isNumber(x: number | string): x is number;
}
declare class Inferrer implements NumberInferrer {
isNumber(x: number | string): boolean;
}
declare let numOrStr: number | string;
declare const inf: Inferrer;
declare class C1 {
isC2(): boolean;
}
declare class C2 extends C1 {
z: number;
}
declare let c: C1;
declare function doNotRefineDestructuredParam({ x, y }: {
x: number | null;
y: number;
}): boolean;
declare function isShortString(x: unknown): boolean;
declare let str: string;
declare function isStringFromUnknown(x: unknown): boolean;
declare function isNumOrStr(x: unknown): boolean;
declare let unk: unknown;
declare function assertAndPredicate(x: string | number | Date): boolean;
declare let snd: string | number | Date;
declare function isNumberWithThis(this: Date, x: number | string): boolean;
declare function narrowFromAny(x: any): boolean;