Fix quick fix for isolatedDeclarations to keep trailing unknown in generics#61227
Merged
jakebailey merged 4 commits intomicrosoft:mainfrom Feb 20, 2025
Merged
Conversation
typescript-bot
added
the
For Uncommitted Bug
jakebailey
reviewed
Feb 20, 2025
Member
jakebailey
left a comment
jakebailey
left a comment
There was a problem hiding this comment.
Would a better fix to just be to check to see how many required type args are needed, and then not cross that threshold? I would think we have a way to access that information.
…aints Also, update the test that this improves.
Contributor
Author
|
Great point! I misremembered what the constraints were when I assumed that we couldn't look up which type arguments were required or not. AFAICT, having a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update
typeToMinimizedReferenceTypehelper to avoid dropping trailingunknowninside generics. This avoids a bug where non-optional trailingunknowntypes were incorrectly dropped.Fixes #61208