MacPlatform: enable GVFS config verb#1159
Merged
Merged
Conversation
nickgra
reviewed
May 14, 2019
| { | ||
| } | ||
|
|
||
| protected POSIXPlatform(UnderConstructionFlags underConstruction) |
Member
There was a problem hiding this comment.
It's not apparent to me from this PR or the description, why does POSIXPlatform not support config?
Member
Author
There was a problem hiding this comment.
I implemented this at the POSIX layer, but I hadn't tested it on a Linux platform. I thought this was a good middle ground between implement at the common layer, but enable at the layer that is tested.
Also, the overarching change will include upgrader related config settings, which also will not be tested on Linux at initially.
wilbaker
suggested changes
May 14, 2019
| public MacPlatform() : base ( | ||
| underConstruction: new UnderConstructionFlags( | ||
| supportsGVFSUpgrade: false, | ||
| supportsGVFSConfig: true)) |
Member
There was a problem hiding this comment.
With this change can the ConfigVerbTests functional tests be turned on for Mac?
jamill
force-pushed
the
upgrader_tasks/gvfs_config
branch
from
aa7df1b to
7a50f15
Compare
wilbaker
approved these changes
May 15, 2019
jamill
force-pushed
the
upgrader_tasks/gvfs_config
branch
from
419698e to
6bcd3c7
Compare
nickgra
approved these changes
May 15, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.